Revert counting attorneys by appointmentType

ministryofjustice · Nov 15, 2024 · abcd41e · abcd41e
1 parent 3ada094
commit abcd41e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/lambda/create/validate.go b/lambda/create/validate.go
@@ -81,10 +81,10 @@ func Validate(lpa shared.LpaInit) []shared.FieldError {
 
 func countAttorneys(as []shared.Attorney, ts []shared.TrustCorporation) (actives, replacements int) {
 	for _, a := range as {
-		switch a.AppointmentType {
-		case shared.AppointmentTypeOriginal:
+		switch a.Status {
+		case shared.AttorneyStatusActive:
 			actives++
-		case shared.AppointmentTypeReplacement:
+		case shared.AttorneyStatusReplacement:
 			replacements++
 		}
 	}

diff --git a/lambda/create/validate_test.go b/lambda/create/validate_test.go
@@ -105,9 +105,9 @@ func TestCountAttorneys(t *testing.T) {
 	assert.Equal(t, 0, replacements)
 
 	actives, replacements = countAttorneys([]shared.Attorney{
-		{AppointmentType: shared.AppointmentTypeReplacement},
-		{AppointmentType: shared.AppointmentTypeOriginal},
-		{AppointmentType: shared.AppointmentTypeReplacement},
+		{Status: shared.AttorneyStatusReplacement},
+		{Status: shared.AttorneyStatusActive},
+		{Status: shared.AttorneyStatusReplacement},
 	}, []shared.TrustCorporation{
 		{Status: shared.AttorneyStatusReplacement},
 		{Status: shared.AttorneyStatusActive},