MLPAB-1552: Attorney moving from paper to online #179
Conversation
| @@ -212,7 +212,16 @@ | |||
| } | |||
| ], | |||
| "type": "object", | |||
| "required": ["dateOfBirth", "email", "status"], | |||
| "required": ["dateOfBirth", "email", "status", "channel"], | |||
There was a problem hiding this comment.
Presumably want to remove email from the default required set?
| "required": ["dateOfBirth", "email", "status", "channel"], | |
| "required": ["dateOfBirth", "status", "channel"], |
There was a problem hiding this comment.
Missed this - yep agree, I'll remove
| @@ -212,7 +212,16 @@ | |||
| } | |||
| ], | |||
| "type": "object", | |||
| "required": ["dateOfBirth", "email", "status"], | |||
| "required": ["dateOfBirth", "email", "status", "channel"], | |||
There was a problem hiding this comment.
a breaking change on the shiny new schema, should this be 2024-04-1?
There was a problem hiding this comment.
but also it isn't required, as the validation hasn't been updated yet. So maybe hold the required change for your next PR
There was a problem hiding this comment.
I think realistically we can break schema for now since no real LPAs are being registered, otherwise we're going to be making new versions pretty much daily.
| "then": { | ||
| "required": ["email"] | ||
| }, | ||
| "required": ["dateOfBirth", "email", "status"], |
There was a problem hiding this comment.
but as Greg says, you may want to remove email (and the existing validation in create) so you can do the consumer side
Partially fixes MLPAB-1552. As with CPs, I've left email and channel optional until I make MRLPA changes (including pact consumer tests) and then I'll loop back round, remove optional and apply
MustMatchExisting.