Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLPAB-1552: Attorney moving from paper to online #179

Merged
merged 7 commits into from
Apr 25, 2024
+131 −6
Merged

MLPAB-1552: Attorney moving from paper to online #179

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c2d25e
add channel to attorney create, add channel and email to attorney update
acsauk Apr 24, 2024
3b50e25
Merge branch 'main' into MLPAB-1552-attorney-moving-from-paper-to-online
acsauk Apr 24, 2024
87417b7
make email optional
acsauk Apr 24, 2024
db49b77
add channel to attorney in apigateway
acsauk Apr 24, 2024
b2b295f
stop requiring channel for attorneys (for now)
acsauk Apr 24, 2024
132b5fa
stop requiring channel for donor details
acsauk Apr 25, 2024
b02807a
stop requiring email for attorney create
acsauk Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions docs/schemas/2024-04/donor-details.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,16 +212,7 @@
}
],
"type": "object",
"required": ["dateOfBirth", "email", "status", "channel"],
"if": {
"required": ["channel"],
"properties": {
"channel": { "const": "online" }
}
},
"then": {
"required": ["email"]
},
"required": ["dateOfBirth", "email", "status"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but as Greg says, you may want to remove email (and the existing validation in create) so you can do the consumer side

"properties": {
"dateOfBirth": {
"type": "string",
Expand Down