VEGA-2260 Record updates in changes table #minor
#98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
townxelliot
had a problem deploying
to
98vega2260a
GitHub Actions
Failure
townxelliot
had a problem deploying
to
98vega2260a
GitHub Actions
Failure
townxelliot
temporarily deployed
to
98vega2260a
GitHub Actions
Inactive
townxelliot
changed the title
changes table #minor
townxelliot
temporarily deployed
to
98vega2260a
GitHub Actions
Inactive
gregtyler
reviewed
Feb 5, 2024
Comment on lines
6
to
-12
| "address": { | ||
| "line1": "79 Bury Rd", | ||
| "town": "Hampton Lovett", | ||
| "postcode": "WR9 2PF", | ||
| "line1": "74 Cloob Close", | ||
| "town": "Mahhhhhhhhhh", | ||
| "country": "GB" | ||
| } |
There was a problem hiding this comment.
This highlighted a bug: postcode should be required if country == GB. I've created a bug ticket for that.
Was there a reason to change this otherwise? Doesn't really matter, just interested.
There was a problem hiding this comment.
@gregtyler it was just that I created my own example JSON, then realised that there was already an example in the repo; so instead I just overwrote what was there with my newer and more correct version
added 19 commits
February 5, 2024 12:17
This is so that we can log the subject recovered from the JWT.
This records the datetime when the update was applied.
townxelliot
force-pushed
the
VEGA2260_audit_trail
branch
from
ab0e022 to
c6f6c3d
Compare
gregtyler
previously approved these changes
Feb 5, 2024
gregtyler
previously approved these changes
Feb 5, 2024
gregtyler
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.