-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VEGA-2260 Record updates in changes table #minor
#98
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
6b91997
Update example to latest LPA spec
4c9f4a5
Fix broken API functional test
51711c3
Make local dynamodb visible to NoSQL workbench
dba8ba0
Modify PUT to use a transaction
80a40b5
Add changes table and wiring into client
6da255a
Create changes table locally and align terraform to it
60aec17
Separate method for put with logging
c492ee1
Reinstate original put method
52fbe41
Return claims from JWT verifier
79248d5
Rename field to applied
e827392
Store extra request data in changes log
1d8b475
Fix tests for new JWT verifier API
1fe1b82
Terraform fix
a8d0e5e
Another terraform fix
f80a310
Create errors in a consistent way
b6cc319
Remove spurious logging
ada2691
Fix typo in JSON serialisation
ceff19d
Add identifier to each update
c6f6c3d
Check update object is properly constructed
f5cdef5
Fix lint error
ccaf459
Prevent 'struct literal uses unkeyed fields' static analysis error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "type": "CERTIFICATE_PROVIDER_SIGN", | ||
| "changes": [ | ||
| { | ||
| "key": "/certificateProvider/address/line1", | ||
| "new": "98 CVVVV", | ||
| "old": null | ||
| }, | ||
| { | ||
| "key": "/certificateProvider/address/town", | ||
| "new": "Murkkkk Town", | ||
| "old": null | ||
| }, | ||
| { | ||
| "key": "/certificateProvider/address/country", | ||
| "new": "GB", | ||
| "old": null | ||
| }, | ||
| { | ||
| "key": "/certificateProvider/signedAt", | ||
| "new": "2024-01-13T22:00:00Z", | ||
| "old": null | ||
| }, | ||
| { | ||
| "key": "/certificateProvider/contactLanguagePreference", | ||
| "new": "en", | ||
| "old": null | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,42 +1,43 @@ | ||
| { | ||
| "lpaType": "personal-welfare", | ||
| "donor": { | ||
| "firstNames": "Homer", | ||
| "surname": "Zoller", | ||
| "dateOfBirth": "1960-04-06", | ||
| "email": "[email protected]", | ||
| "firstNames": "Feeg", | ||
| "lastName": "Bundlaaaa", | ||
| "address": { | ||
| "line1": "79 Bury Rd", | ||
| "town": "Hampton Lovett", | ||
| "postcode": "WR9 2PF", | ||
| "line1": "74 Cloob Close", | ||
| "town": "Mahhhhhhhhhh", | ||
| "country": "GB" | ||
| } | ||
| }, | ||
| "dateOfBirth": "1970-01-24", | ||
| "email": "[email protected]" | ||
| }, | ||
| "attorneys": [ | ||
| { | ||
| "firstNames": "Jake", | ||
| "surname": "Vallar", | ||
| "dateOfBirth": "2001-01-17", | ||
| "email": "[email protected]", | ||
| "status": "active", | ||
| "address": { | ||
| "line1": "71 South Western Terrace", | ||
| "town": "Milton", | ||
| "postcode": "6306", | ||
| "country": "AU" | ||
| } | ||
| }, | ||
| { | ||
| "firstNames": "Tory", | ||
| "surname": "Lapolla", | ||
| "dateOfBirth": "1989-12-29", | ||
| "status": "replacement", | ||
| "firstNames": "Herman", | ||
| "lastName": "Seakrest", | ||
| "address": { | ||
| "line1": "184 Bayside Apartments", | ||
| "line2": "East Street", | ||
| "line3": "Saratosa", | ||
| "town": "Polebrook", | ||
| "country": "US" | ||
| } | ||
| "line1": "81 NighOnTimeWeBuiltIt Street", | ||
| "town": "Mahhhhhhhhhh", | ||
| "country": "GB" | ||
| }, | ||
| "dateOfBirth": "1982-07-24", | ||
| "email": "[email protected]", | ||
| "status": "active" | ||
| } | ||
| ] | ||
| ], | ||
| "certificateProvider": { | ||
| "firstNames": "Vone", | ||
| "lastName": "Spust", | ||
| "address": { | ||
| "line1": "122111 Zonnington Way", | ||
| "town": "Mahhhhhhhhhh", | ||
| "country": "GB" | ||
| }, | ||
| "channel": "online", | ||
| "email": "[email protected]" | ||
| }, | ||
| "lifeSustainingTreatmentOption": "option-a", | ||
| "signedAt": "2024-01-10T23:00:00Z", | ||
| "certificateProviderNotRelatedConfirmedAt": "2024-01-11T22:00:00Z" | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This highlighted a bug: postcode should be required if country == GB. I've created a bug ticket for that.
Was there a reason to change this otherwise? Doesn't really matter, just interested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gregtyler it was just that I created my own example JSON, then realised that there was already an example in the repo; so instead I just overwrote what was there with my newer and more correct version