Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of the pathreparam integrator #44

Closed
wants to merge 30 commits into from
Closed

Implementation of the pathreparam integrator #44

wants to merge 30 commits into from

Conversation

Speierers
Copy link
Member

@Speierers Speierers commented Mar 25, 2020 •
edited by merlinND
Loading

This pull request proposes new integrator that implements the paper "Reparameterizing Discontinuous Integrands for Differentiable Rendering".

TODOs:

  • Support for envmap
  • Support for multiple emitters
  • Always use convolution with adaptive kernel angular support
  • Add existing tests to test suite
  • Remove path-reparam-old integrator (used for comparison)
  • Reduce calls to gather and scatter when doubling path for control variate.
  • Write documentation
  • Write tutorials

Closes #26.

@Speierers Speierers mentioned this pull request Mar 25, 2020
Closed
loubetg and others added 15 commits March 26, 2020 09:09
@loubetg
Add back sampling of all scene emitters
0f949c1
@loubetg
Change plugin name (pathreparam is the new version)
58ece2b
@Speierers
Clean helper functions in path-reparm-utils.h
e455be3
@Speierers
Rearrange methods in scene.h and scene.cpp
8f17d4d
@Speierers
Only compute p and n for occluder si
b050427
@loubetg
Tmp fix scene::sample_emitter
f980518
@loubetg
Add support for envmap convolutions
d961c00
@Speierers
Change ray_intersect API adding HitComputeMode
8a3f39b 
- ray_intersect takes an optional HitComputeMode argument
- change return behavior of fill_surface_interaction
- upgrade pathreparam integrator
@loubetg
Fix sample_emitter fast path for packets and GPU arrays
b58010e
@Speierers
Remove pathreparamold and helper functions
0bf65e3
@loubetg
Fill sampled_roughness field for rough materials
e5aa887
@loubetg
Update class name for path-reparam, remove useless any_or<> checks
74411d9
@loubetg
Minor fix, replace sliding term by reparam
eef3c18
@loubetg
Update documentation for path-reparam
b86957e
@Speierers
Minor cleanup in autodiff.py
16ffc31
@Speierers Speierers mentioned this pull request Apr 1, 2020
Closed
@abhinavvs abhinavvs mentioned this pull request Apr 7, 2020
Closed
@merlinND merlinND mentioned this pull request Apr 10, 2020
Closed
@merlinND merlinND mentioned this pull request Apr 30, 2020
Closed
@mmgutsche
Copy link

From the todos it seems like only documentation is missing? Is it from the API any different and would basically fix #26 ?

@Speierers
Copy link
Member Author

@mmgutsche We are still working on some implementation details, especially the way this new integrator deals with envmap.
On top of that, this PR won't be merge before we merge #88 . Rebasing from this will be quite some work as well.

Feel free to give it a try, you can have a look at the test script that comes with this PR for some examples.

@udemegane
Copy link

udemegane commented May 9, 2020 •
edited
Loading

I came here from a problem with #26, and I'd like to try the test script, what directory is it in?
Thank you.

@arpit15
Copy link
Contributor

arpit15 commented May 9, 2020

https://github.com/loubetg/mitsuba2-reparam-tests repo has some examples. I get Nan sometimes when running these scripts.

@udemegane
Copy link

I'm going to try this soon. Thanks for the quick reply!

@Speierers Speierers mentioned this pull request May 28, 2020
Draft
@Speierers
Copy link
Member Author

Work on this will continue in a seperate PR: #157

The reason for this is to ensure compatibility with the pathreparam tests suite.

The new PR was rebased onto master and now uses OptiX 7.

@Speierers Speierers closed this May 28, 2020
@lo-zed lo-zed mentioned this pull request Feb 4, 2021
Open
@chongxian chongxian mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Speierers Speierers

@loubetg loubetg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geometric differentiation does not yet work
5 participants
@Speierers @mmgutsche @udemegane @arpit15 @loubetg