[WIP] Config refactoring #615
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now all settings are distributed among hardcoded (and updated during init) values at `config.py`, and dynamic (loaded from .yaml file) profile's `ConfigManager`. So there is a confusion - which module is responsible for what. In future I'm going to move all dynamic values to `ConfigManager`, ensuring `settings` is just a hardcoded list of default init values and is never rewritten.
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
VukW
requested a deployment
to
testing-external-code
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now configuration process is quite a complex: settings are spread over two places (
config.pyand yaml profiles), both are rewritten multiple times during app init, with possible overriding by CLI params. At the same time some settings likeUI,Auth,Commsobjects are fixed just once at the very start of the app and cannot be reconfigured easily later.However, for web-UI we aim to support a runtime change of profile / auth, so user can log in and use web-ui without restarting CLI command. For that I do need to refactor config init approach - and, at the same time, it's possible to simplify configuration init for the future usage.