Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Config refactoring #615

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[WIP] Config refactoring #615

wants to merge 8 commits into from

Commits on Aug 30, 2024

  1. Resolved confusion between config.py and config_manager.py 

    Right now all settings are distributed among hardcoded (and updated during init) values at `config.py`, and dynamic (loaded from .yaml file) profile's `ConfigManager`.
So there is a confusion - which module is responsible for what. In future I'm going to move all dynamic values to `ConfigManager`, ensuring `settings` is just a hardcoded list of default init values and is never rewritten.
    @VukW
    VukW committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    118020c View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Reset config before every test

    @VukW
    VukW committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9b2cffc View commit details
    Browse the repository at this point in the history

  2. Moved UI to the dynamic config

    @VukW
    VukW committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    4bd5878 View commit details
    Browse the repository at this point in the history

  3. UIFactory class is not necessary as it doesn't store any state

    @VukW
    VukW committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a9f06a8 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Moved comms to the config

    @VukW
    VukW committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    67be01d View commit details
    Browse the repository at this point in the history

  2. Moved auth to config also

    @VukW
    VukW committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    85da36e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Linter fix

    @VukW
    VukW committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    1dc4938 View commit details
    Browse the repository at this point in the history

  2. Linter fix

    @VukW
    VukW committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    dfeb040 View commit details
    Browse the repository at this point in the history