plot_evoked_field: fix not being able to tweak the vmin/vmax of the field lines when plot_density=False
#13048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only change is the removal of |
for more information, see https://pre-commit.ci
larsoner
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Worth a bugfix changelog entry or no?
The only change is the removal of if self._show_density: and then an un-indenting of everything by one level.
👍 in case anyone doesn't know about this cool GitHub feature:
ticking the "hide whitespace" box and reloading made it very easy to review!
It's a user facing change, so I guess there should be an entry. |
qian-chu
pushed a commit
to qian-chu/mne-python
that referenced
this pull request
Jan 20, 2025
… the field lines when `plot_density=False` (mne-tools#13048) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This concerns the UI in the interactive
plot_evoked_fieldviewer of magnetic field lines.In my initial implementation, I mistakenly thought that the input boxes for
vminandvmaxwould only apply to the color "blobs" on the mesh whenplot_density=True. But they also (correctly) apply to the contour lines (i.e. the magnetic field lines). Hence, we don't want these input boxes hidden whenplot_density=False.