Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_evoked_field: fix not being able to tweak the vmin/vmax of the field lines when plot_density=False #13048

Merged
merged 5 commits into from
Jan 8, 2025
Merged

plot_evoked_field: fix not being able to tweak the vmin/vmax of the field lines when plot_density=False #13048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5912f6e
also show field strength input fields when not plotting density
wmvanvliet Jan 7, 2025
c56add1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 7, 2025
8811358
add changelog
wmvanvliet Jan 8, 2025
719b1bd
Merge branch 'main' into evoked-field-ui
wmvanvliet Jan 8, 2025
67a97f1
Merge branch 'main' into evoked-field-ui
larsoner Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/devel/13048.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix input boxes for the max value not showing when plotting fieldlines with :func:`~mne.viz.plot_evoked_field` when ``show_density=False``, by `Marijn van Vliet`_.
69 changes: 30 additions & 39 deletions mne/viz/evoked_field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,45 +380,36 @@ def _configure_dock(self):
# Fieldline configuration
layout = r._dock_add_group_box("Fieldlines")

if self._show_density:
r._dock_add_label(value="max value", align=True, layout=layout)

@_auto_weakref
def _callback(vmax, kind, scaling):
self.set_vmax(vmax / scaling, kind=kind)

for surf_map in self._surf_maps:
if surf_map["map_kind"] == "meg":
scaling = DEFAULTS["scalings"]["grad"]
else:
scaling = DEFAULTS["scalings"]["eeg"]
rng = [0, np.max(np.abs(surf_map["data"])) * scaling]
hlayout = r._dock_add_layout(vertical=False)

self._widgets[f"vmax_slider_{surf_map['map_kind']}"] = (
r._dock_add_slider(
name=surf_map["map_kind"].upper(),
value=surf_map["map_vmax"] * scaling,
rng=rng,
callback=partial(
_callback, kind=surf_map["map_kind"], scaling=scaling
),
double=True,
layout=hlayout,
)
)
self._widgets[f"vmax_spin_{surf_map['map_kind']}"] = (
r._dock_add_spin_box(
name="",
value=surf_map["map_vmax"] * scaling,
rng=rng,
callback=partial(
_callback, kind=surf_map["map_kind"], scaling=scaling
),
layout=hlayout,
)
)
r._layout_add_widget(layout, hlayout)
r._dock_add_label(value="max value", align=True, layout=layout)

@_auto_weakref
def _callback(vmax, kind, scaling):
self.set_vmax(vmax / scaling, kind=kind)

for surf_map in self._surf_maps:
if surf_map["map_kind"] == "meg":
scaling = DEFAULTS["scalings"]["grad"]
else:
scaling = DEFAULTS["scalings"]["eeg"]
rng = [0, np.max(np.abs(surf_map["data"])) * scaling]
hlayout = r._dock_add_layout(vertical=False)

self._widgets[f"vmax_slider_{surf_map['map_kind']}"] = r._dock_add_slider(
name=surf_map["map_kind"].upper(),
value=surf_map["map_vmax"] * scaling,
rng=rng,
callback=partial(_callback, kind=surf_map["map_kind"], scaling=scaling),
double=True,
layout=hlayout,
)
self._widgets[f"vmax_spin_{surf_map['map_kind']}"] = r._dock_add_spin_box(
name="",
value=surf_map["map_vmax"] * scaling,
rng=rng,
callback=partial(_callback, kind=surf_map["map_kind"], scaling=scaling),
layout=hlayout,
)
r._layout_add_widget(layout, hlayout)

hlayout = r._dock_add_layout(vertical=False)
r._dock_add_label(
Expand Down
Loading