Don't trigger unneeded ActionSpyEvent for AsyncAction

[s0nerik]

Fixes #734

[netlify]

✅ Deploy Preview for mobx canceled.

Name	Link
🔨 Latest commit	4f42d38
🔍 Latest deploy log	https://app.netlify.com/sites/mobx/deploys/62a20f9dc01b310008fa5e5b

[codecov]

Codecov Report

Merging #784 (4f42d38) into master (45248a9) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #784      +/-   ##
==========================================
- Coverage   98.81%   98.80%   -0.01%     
==========================================
  Files          56       56              
  Lines        1933     1931       -2     
==========================================
- Hits         1910     1908       -2     
  Misses         23       23              

Flag	Coverage Δ
flutter_mobx	100.00% <ø> (ø)
mobx	98.32% <100.00%> (-0.01%)	⬇️
mobx_codegen	100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mobx/lib/src/api/async/async_action.dart	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45248a9...4f42d38. Read the comment docs.

[fzyzcjy]

Could you please add a bit of tests to verify it :)

[s0nerik]

Could you please add a bit of tests to verify it :)

Yes! I've added a test that verifies the correct behavior. It breaks on master (eventCount == 4) and works correctly with my patch (eventCount == 1).

I've also identified that my previous guess about the reasons for extra events being reported might've been wrong. I couldn't reproduce the problem using "continuations" in the test environment, but easily did it with scheduleMicrotask.

[fzyzcjy]

LGTM

[pavanpodila]

Please add the Changelog, bump up the version with +2 on mobx. Make sure to invoke set-versions via npm or directly on terminal

[s0nerik]

@pavanpodila please take a look. I've updated the version as you requested.

[makstheimba]

Any progress on this? We are really waiting for this change as await is unusable without it

[pavanpodila]

It's missing some changes to move forward

[s0nerik]

@pavanpodila I've already updated the versions as you requested, twice. But since other commits get merged (often overriding the version you've requested me to adjust) and this one stays without attention, I'm not sure when I need to apply the changes to make the merge happen.

I simply don't have enough time to monitor every commit in this repository to apply the version adjustment time and time again.

[pavanpodila]

Let me check. I'm in transit now

[pavanpodila]

@all-contributors add @s0nerik for code

[allcontributors]

@pavanpodila

@s0nerik already contributed before to code

[amondnet]

@pavanpodila This pr failed tests.

https://github.com/mobxjs/mobx.dart/runs/6815659674?check_suite_focus=true

dart run test test/async_action_test.dart -N "run allows updating observable values in an async function"

00:00 +0 -1: AsyncAction run allows updating observable values in an async function [E]                                                                                                                     
  Expected: [0, 2, 3]
    Actual: [0, 3]
     Which: at location [1] is <3> instead of <2>
  
  package:test_api                  expect
  test/async_action_test.dart 42:7  main.<fn>.<fn>
  
00:00 +0 -1: Some tests failed.