Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name to WHEN_TIMEOUT error if available #3599

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

evelant
Copy link

@evelant evelant commented Dec 31, 2022

It's useful to have a name attached to the WHEN_TIMEOUT error for debugging/tracing. Since when already takes a name as an option this PR just adds the name to the WHEN_TIMEOUT error if it is available.

Code change checklist

  • [X ] Added/updated unit tests
  • [X ] Updated /docs. For new functionality, at least API.md should be updated
  • [X ] Verified that there is no significant performance drop (yarn mobx test:performance)

@changeset-bot
Copy link

changeset-bot bot commented Dec 31, 2022

⚠️ No Changeset found

Latest commit: 650166f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@mweststrate mweststrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late follow up. I imagine WHEN_TIMEOUT is an error message that is programmatically checked against in catch handlers, so I think it'd be better to store the debug name in a separate property on the same error object. E.g whenName or something like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants