Unit checking #3255
Draft
Unit checking #3255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
added
the
MCP
HansOlsson
added
MCP0027
This was referenced Dec 6, 2022
|
@HansOlsson, @casella how do you feel about rebranding MCP-0027 as Unit checking in order to avoid abandoning this MCP just to open up another one with broader scope? |
|
I wonder if it's worth carrying all the history of this MCP. We could close this and keep it for the record. Maybe a a fresh start with a new one would be better? |
|
I believe it makes sense to rebrand MCP-0027 as Unit checking; instead of "Units of Literal Constants". I understand the concern by @casella - but to me it suffices to start a new PR if needed, and having all of the unit-issues and pull requests with the same label MCP-0027 label will make it easier to keep track of everything we have found out so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR of MCP-0027.
Opening as Draft pull request, reflecting the current MCP status being In Development.
A long discussion foregoing this PR can be found in #2127.