Avoid syntax errors. #3496
Open
Avoid syntax errors. #3496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
requested changes
Apr 3, 2024
There was a problem hiding this comment.
I find the old way with {} much more clear, and it has never been a concern to me that annotations are defined using a style which only reminds of – but isn't exactly – Modelica.
We already have the big discrepancy that there is no built-in record called Documentation, and that's not a problem.
I see two better-looking alternatives to fill("foo", 0):
- General use of
{}rather thanfill("foo", 0)when defining annotations with defaults. - General rule that array annotations always default to being empty. (Corresponding to suggestion in Define more annotations as declarations #3448 (comment).)
henrikt-ma
requested changes
May 31, 2024
HansOlsson
commented
Jan 9, 2025
|
Since we now define that an array defaults to being empty we can handle it by just removing the default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid the use of
{}that isn't described in the grammar.