Sensible quoting. #3566
Merged
Sensible quoting. #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikt-ma
previously requested changes
Sep 2, 2024
eshmoylova
reviewed
Sep 2, 2024
Remove note to proceed Co-authored-by: Henrik Tidefelt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous variant didn't make sense.
The change is that when we discuss environment variables in general it doesn't make sense to include quotes (especially when we use a different font), you just set the environment variable to the specified value in some GUI/shell. However, if you want to show the value in Modelica (or C) quotes are needed, but the backslashes also needs to be doubled.
A completely different idea would be to allow quotes around specific elements of the MODELICAPATH as in
"C:\library";"C:\lib1";C:\lib2. I have some vague idea that it was used at some point in time on Windows, but likely with space;as separator. I thus don't see that we need to mention that.