Default Icon; more or less according to decision. #3624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing a name for it to make it easier to refer to, and to break up the long sentence. Closes modelica#3613
HansOlsson
changed the title
perost
reviewed
Dec 9, 2024
HansOlsson
commented
Dec 9, 2024
henrikt-ma
reviewed
Dec 10, 2024
henrikt-ma
reviewed
Dec 10, 2024
Took me a while to find this rationale, but as explained above I'm not sure we should introduce a concept for this situation, and what I suggested is another way to break up the long sentence. |
henrikt-ma
reviewed
Dec 11, 2024
Co-authored-by: Henrik Tidefelt <[email protected]>
Co-authored-by: Henrik Tidefelt <[email protected]>
HansOlsson
commented
Dec 11, 2024
henrikt-ma
reviewed
Dec 11, 2024
Co-authored-by: Henrik Tidefelt <[email protected]>
henrikt-ma
reviewed
Dec 11, 2024
henrikt-ma
reviewed
Dec 20, 2024
henrikt-ma
requested changes
Dec 20, 2024
There was a problem hiding this comment.
Before approving without a non-normative sentence like this,
That \lstinline!visible!-attributes are not regarded makes it possible to obtain an icon which only shows connectors by adding a dummy primitive with \lstinline!visible = false!.
I'd like to see a language group poll against adding it. Otherwise, I'll have a hard time explaining to my colleague why such a simple clarification could not be added.
Reviewing with Request changes while waiting for the outcome of the poll.
Co-authored-by: Henrik Tidefelt <[email protected]>
|
Language group: Add that non-normative text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a name for it to make it easier to refer to, and to break up the long sentence.
Closes #3613