[stdlib] Implement Writer for List[Byte] #3758
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Hermann <[email protected]>
lsh
changed the title
JoeLoser
reviewed
Nov 10, 2024
| @@ -592,6 +621,18 @@ struct List[T: CollectionElement, hint_trivial_type: Bool = False]( | |||
| # list. | |||
| self.size = final_size | |||
|
|
|||
| fn extend(inout self, other: Span[T]): | |||
There was a problem hiding this comment.
Suggestion Add some unit tests for this new public API method.
| assert_equal(l[0], ord("a")) | ||
| assert_equal(l[1], ord("b")) | ||
| assert_equal(l[2], ord("c")) | ||
| var l2 = List[Byte]() |
There was a problem hiding this comment.
Question Can you explain this part of the test? I'm not sure I follow.
martinvuyk
reviewed
Nov 10, 2024
| null terminated. | ||
| """ | ||
| constrained[_type_is_eq[T, Byte]()]() | ||
| self.extend(rebind[Span[T, bytes.origin]](bytes)) |
There was a problem hiding this comment.
the extend method has a lot of overhead if you know it's a DType. Until we land #3577 this logic will have to stay here
Suggested change
| self.extend(rebind[Span[T, bytes.origin]](bytes)) | |
| self.reserve(len(self) + len(bytes)) | |
| memcpy( | |
| self.unsafe_ptr() + len(self), | |
| bytes.unsafe_ptr().bitcast[T](), | |
| len(bytes), | |
| ) |
|
I'll sync this internally for you so you can iterate on it in-tree. |
|
!sync |
modularbot
added
the
imported-internally
JoeLoser
added
the
waiting for response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
Writertrait toListwith a constraint that theTisByte.