-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Implement Writer for List[Byte] #3758
Open
lsh
wants to merge
1
commit into
modularml:nightly
Choose a base branch
from
lsh:lsh/list-writer
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -419,6 +419,35 @@ struct List[T: CollectionElement, hint_trivial_type: Bool = False]( | |
self.write_to(output) | ||
return output^ | ||
|
||
fn write_bytes(inout self, bytes: Span[Byte, _]): | ||
""" | ||
Write a byte span to this List. `T` **must** be of type `Byte`. | ||
|
||
Args: | ||
bytes: The byte span to write to this String. Must NOT be | ||
null terminated. | ||
""" | ||
constrained[_type_is_eq[T, Byte]()]() | ||
self.extend(rebind[Span[T, bytes.origin]](bytes)) | ||
|
||
fn write[*Ts: Writable](inout self, *args: *Ts): | ||
"""Write a sequence of Writable arguments to the provided Writer. | ||
`T` **must** be of type `Byte`. | ||
|
||
Parameters: | ||
Ts: Types of the provided argument sequence. | ||
|
||
Args: | ||
args: Sequence of arguments to write to this Writer. | ||
""" | ||
constrained[_type_is_eq[T, Byte]()]() | ||
|
||
@parameter | ||
fn write_arg[T: Writable](arg: T): | ||
arg.write_to[__type_of(self)](self) | ||
|
||
args.each[write_arg]() | ||
|
||
@no_inline | ||
fn write_to[ | ||
W: Writer, U: RepresentableCollectionElement, // | ||
|
@@ -592,6 +621,18 @@ struct List[T: CollectionElement, hint_trivial_type: Bool = False]( | |
# list. | ||
self.size = final_size | ||
|
||
fn extend(inout self, other: Span[T]): | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggestion Add some unit tests for this new public API method. |
||
"""Extends this list by copying the elements of `other`. | ||
|
||
Args: | ||
other: Span whose elements will be added in order at the end of this list. | ||
""" | ||
var final_size = len(self) + len(other) | ||
self.reserve(final_size) | ||
|
||
for item in other: | ||
self.append(item[]) | ||
|
||
fn pop(inout self, i: Int = -1) -> T: | ||
"""Pops a value from the list at the given index. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -922,6 +922,19 @@ def test_list_repr(): | |
assert_equal(empty.__repr__(), "[]") | ||
|
||
|
||
def test_writer(): | ||
var l = List[Byte]() | ||
var s = "abc".as_bytes() | ||
l.write_bytes(s) | ||
assert_equal(l[0], ord("a")) | ||
assert_equal(l[1], ord("b")) | ||
assert_equal(l[2], ord("c")) | ||
var l2 = List[Byte]() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question Can you explain this part of the test? I'm not sure I follow. |
||
assert_equal(l2[0], 0) | ||
assert_equal(l2[1], 1) | ||
assert_equal(l2[2], 2) | ||
|
||
|
||
# ===-------------------------------------------------------------------===# | ||
# main | ||
# ===-------------------------------------------------------------------===# | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the extend method has a lot of overhead if you know it's a
DType
. Until we land #3577 this logic will have to stay here