DOP-4247: New Github Action to build docs site artifact #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
minor. theres a few typescript errors from the CI / TS tests. most are fixable with vscode formatter using eslint but some are not automatic |
rayangler
reviewed
Feb 2, 2024
seungpark
reviewed
Feb 2, 2024
rayangler
approved these changes
Feb 5, 2024
| } | ||
| }); | ||
|
|
||
| await once(rl, 'close'); |
There was a problem hiding this comment.
This is cool. I didn't know you can use an event like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-4247
Notes
This new custom Github Action is created to download build artifacts of a docs site so that later in the pipeline another Action can run a Lighthouse score on the built site.
It fetches the most recent build data from the Snooty Data API per the project designated, parses the data apart into a similar structure as our zipped manifests, and saves them to the process for Snooty to use in a build.
There is a companion PR in Snooty to be opened soon.
Behavior with both PRs
Cloud-docs
Server Docs
^ note above you can download the build artifacts