DOP-4247: Build Artifacts #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayangler
reviewed
Feb 2, 2024
branberry
reviewed
Feb 2, 2024
seungpark
reviewed
Feb 2, 2024
There was a problem hiding this comment.
the output looks great! a couple comments below for usage of artifacts between Access Build Data to Build Snooty steps
also, guessing this is from a previous commit, but this action shows artifact with name lighthouse-cloud-docs.zip - where is the lighthouse coming from?
| run: | | ||
| npm ci --legacy-peer-deps | ||
| npm run build | ||
| - name: Save Artifact |
There was a problem hiding this comment.
laying the law for DOP-4248 ❤️
|
Refactored with all feedback taken into account. Also, for cleanliness, depending on a new env var |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stories/Links:
DOP-4247
Links to Builds:
Cloud-docs
Server Docs
^ note above you can download the build artifacts
Notes:
This PR utilizes the new (PR) Github Action to download latest build data of the desired project, build the docs site, and save the build bundle to an Artifact.
I've set up one workflow for each desired project.
Because of using data from the Snooty Data API, even with mimicking the structure of our manifest files, there were minimal changes necessary to ingest this within Snooty.