CLOUDP-277700: Reduced reconcile period for externally linked resources #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helderjs
requested review from
s-urbaniak,
josvazg,
igor-karpukhin,
roothorp and
cveticm
helderjs
temporarily deployed
to
openshift-test
GitHub Actions
Inactive
s-urbaniak
approved these changes
Oct 8, 2024
josvazg
reviewed
Oct 9, 2024
Comment on lines
+205
to
209
| if atlasDatabaseUser.Spec.ExternalProjectRef != nil { | ||
| return workflow.Requeue(workflow.StandaloneResourceRequeuePeriod).ReconcileResult() | ||
| } | ||
|
|
||
| return workflow.OK().ReconcileResult() |
There was a problem hiding this comment.
This is the only place we exit OK right?
josvazg
reviewed
Oct 9, 2024
| DefaultRetry = time.Second * 10 | ||
| DefaultTimeout = time.Minute * 20 | ||
| DefaultRetry = time.Second * 10 | ||
| StandaloneResourceRequeuePeriod = time.Minute * 15 |
There was a problem hiding this comment.
We said we would make this configurable down to 5 mins minimum. We can do it on a follow up.
There was a problem hiding this comment.
TD doc says it's 15 minutes. That's why I set it as the value
There was a problem hiding this comment.
Thanks for the heads up, I have fixed the TD to reiterate what was said in the scope, this should be configurable before release and 5 minutes is the minimum value allowed.
josvazg
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if there is one).