-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-277700: Reduced reconcile period for externally linked resources #1854
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,9 @@ import ( | |
) | ||
|
||
const ( | ||
DefaultRetry = time.Second * 10 | ||
DefaultTimeout = time.Minute * 20 | ||
DefaultRetry = time.Second * 10 | ||
StandaloneResourceRequeuePeriod = time.Minute * 15 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We said we would make this configurable down to 5 mins minimum. We can do it on a follow up. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TD doc says it's 15 minutes. That's why I set it as the value There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the heads up, I have fixed the TD to reiterate what was said in the scope, this should be configurable before release and 5 minutes is the minimum value allowed. |
||
DefaultTimeout = time.Minute * 20 | ||
) | ||
|
||
type Result struct { | ||
|
@@ -30,6 +31,13 @@ func OK() Result { | |
} | ||
} | ||
|
||
func Requeue(period time.Duration) Result { | ||
return Result{ | ||
terminated: false, | ||
requeueAfter: period, | ||
} | ||
} | ||
|
||
// Terminate indicates that the reconciliation logic cannot proceed and needs to be finished (and possibly requeued). | ||
// This is not an expected termination of the reconciliation process so 'warning' flag is set to 'true'. | ||
// 'reason' and 'message' indicate the error state and are supposed to be reflected in the `conditions` for the | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only place we exit OK right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes