Fix legacy registry action #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agusrodri
approved these changes
Mar 4, 2024
elfedy
reviewed
Mar 4, 2024
elfedy
reviewed
Mar 4, 2024
| @@ -42,4 +42,9 @@ cd .. | |||
| echo "Running ./scripts/update-tracing-runtime-lock.sh $SPEC_VERSION ..." | |||
| source ./scripts/update-tracing-runtime-lock.sh $SPEC_VERSION | |||
|
|
|||
| echo "Format with cargo fmt" | |||
There was a problem hiding this comment.
Not sure that you need this in theory as format should be applied on moonbeam repo if we had the check, and if we don't there's no need to format.
There was a problem hiding this comment.
the ci is always failing on for cargo fmt check, I prefer that we format before pushing
There was a problem hiding this comment.
Maybe remove the cargo fmt check is better in order to be consistent with the main repo?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.