Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy registry action #86

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Fix legacy registry action #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8d1885
permanently copy shared resources in the runtime override source folder
noandrea Mar 4, 2024
34d3f08
update checkout action version
noandrea Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ on:
types: [opened, edited, synchronize]

jobs:

list-spec-versions:
if: github.event.pull_request.draft == false
runs-on: ubuntu-latest
outputs:
spec_versions: ${{ steps.list-versions.outputs.spec_versions }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: List spec versions
Expand All @@ -37,7 +36,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Find un-copyrighted files
Expand All @@ -55,7 +54,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Setup editorconfig checker
Expand All @@ -80,7 +79,7 @@ jobs:
spec_version: ${{ fromJson(needs.list-spec-versions.outputs.spec_versions) }}
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }}
- uses: dorny/paths-filter@v2
Expand All @@ -98,6 +97,6 @@ jobs:
# if: steps.filter.outputs.edited == 'true' || steps.filter.outputs.shared == 'true'
# run: cd tracing/${{ matrix.spec_version }} && cargo test --release --all
- name: "Check wasm blob"
if: steps.filter.outputs.edited == 'true' || steps.filter.outputs.shared == 'true'
if: steps.filter.outputs.edited == 'true' || steps.filter.outputs.shared == 'true'
run: |
./scripts/check-tracing-runtime.sh ${{ matrix.spec_version }}
3 changes: 1 addition & 2 deletions .github/workflows/create-tracing-runtime.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@ on:
required: false

jobs:

create-tracing-runtime:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: import runtime
run: |
./scripts/import-tracing-runtime.sh ${{ github.event.inputs.spec_version }} ${{ github.event.inputs.moonbeam_git_ref }}
Expand Down
5 changes: 5 additions & 0 deletions scripts/import-tracing-runtime.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,9 @@ cd ..
echo "Running ./scripts/update-tracing-runtime-lock.sh $SPEC_VERSION ..."
source ./scripts/update-tracing-runtime-lock.sh $SPEC_VERSION

echo "Format with cargo fmt"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that you need this in theory as format should be applied on moonbeam repo if we had the check, and if we don't there's no need to format.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ci is always failing on for cargo fmt check, I prefer that we format before pushing

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the cargo fmt check is better in order to be consistent with the main repo?

pushd tracing/$SPEC_VERSION
cargo fmt
popd

echo "Done !"
5 changes: 1 addition & 4 deletions scripts/update-tracing-runtime-lock.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,4 @@ echo
cargo fetch
echo

echo "Removing shared directory in tracing/${VERSION}"
rm -rf shared

cd ../..
cd ../..
Loading