Modern C++ best practices

[tylerjw]

Systematically go through Jason Turner's book and https://github.com/cpp-best-practices/cppbestpractices and apply modern C++ best practices to MoveIt.

Related Issues:

• Replace NULL with nullptr #841
• Test with address sanitizer #842
• Test with thread sanitizer #843
• Enable recommended set of warnings #844
• Coverity scanning #845
• cppcheck linting #846
• IKOS linting #847
• Heap memory profiling #848
• Hotspot perf profiling #849
• Test with memory sanitizer #850
• Test with undefined behavior sanitizer #851
• Standardize comment style #852
• Never Use using namespace in a Header File #853
• {} Are Required for Blocks. #854
• Initialize Member Variables #855
• Assigning default values with brace initialization #856
• Use .hpp extension for headers #857
• Consider the Rule of Zero #858
• Do not pass and return simple types by const ref #859
• Do not pass and return simple types by const ref #859
• Avoid Raw Memory Access (prefer make_* functions) #860
• Use std::array or std::vector Instead of C-style Arrays #861
• Use C++-style cast instead of C-style cast #862
• Avoid Raw Loops (remove operator[]) #863
• Mutex and mutable go together #864
• Forward Declare When Possible #865
• Analyze the Build Time #866
• Use Initializer Lists #867
• Get rid of “new” #868
• Prefer unique_ptr to shared_ptr #869
• Prefer ++i to i++ #870
• Char is a char, string is a string #871
• Never Use std::bind #872
• Prefer double to float, But Test First #873
• Limit Variable Scope #874
• Get rid of std::endl #875
• Kill shared_ptr copies #876
• Enable move operations #877
• Carefully consider return types #878
• Const as much as possible #879
• Avoid implicit conversions #880
• Use the correct integer type for standard library features #881
• Convert to modern include guard #882

[v0nser]

Hey! I would love to contribute to this project.

[tylerjw]

Hey! I would love to contribute to this project.

You are welcome to. Please just take one of the open issues and submit a PR for it.

[tarunkartik]

Interested in contributing to this effort. From my experience, a lot of these issues can be solved using certain CMake flags and running clang-tidy.