Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FXIOS-10386 #22756 Add debug logs for handling route #24218

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

lmarceau
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Adding some debug logs inside our handle route path. I am trying to understand why the route is not handled in the case shown in the bug logs.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@lmarceau lmarceau requested a review from a team as a code owner January 17, 2025 17:30
@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 33.52%
📖 Edited 2 files
📖 Created 0 files

Client.app: Coverage: 32.4

File Coverage
BaseCoordinator.swift 93.94%
SceneDelegate.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against 48ba965

@mattreaganmozilla
Copy link
Collaborator

I don't have full context on FXIOS-10386 but it looks like it might possibly be a dup of the longstanding deeplink issue we've had which was escalated to Apple as a DTS incident. I believe the main ticket tracking that was https://mozilla-hub.atlassian.net/browse/FXIOS-7799. There was a pretty deep investigation on that one.

@lmarceau lmarceau merged commit 1390006 into main Jan 20, 2025
10 checks passed
@lmarceau lmarceau deleted the lm/FXIOS-10386-#22756-adding-logs branch January 20, 2025 19:53
clarmso pushed a commit that referenced this pull request Jan 22, 2025
@lmarceau
Copy link
Contributor Author

@Mergifyio backport release/v135

Copy link
Contributor

mergify bot commented Jan 30, 2025

backport release/v135

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 30, 2025
rvandermeulen pushed a commit that referenced this pull request Feb 7, 2025
…4218) (#24466)

Add FXIOS-10386 #22756 Add debug logs for handling route (#24218)

Adding logs

(cherry picked from commit 1390006)

Co-authored-by: lmarceau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants