Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WNP128 for Firefox #14720
Add WNP128 for Firefox #14720
Changes from 5 commits
4223df9
93b9aa3
c47c4dc
970c5b7
b316591
1a83d88
7a49e1a
3f70d0a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW I'm not sure how well the image+text renders for you, I'm having better results with additional e.g.
line-height: 2
aligning it better inside the button.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Would this be better in whatsnew/base to just set and forget?
(or another base template for that matter — i silently expected the og:description being set to the same as meta description tbh…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, og sets
self.page_desc()
:bedrock/bedrock/base/templates/base-protocol.html
Line 39 in 2656cbd
& meta leaves to the
page_desc
block:bedrock/bedrock/base/templates/base-protocol.html
Line 32 in 2656cbd
that is never set further (firefox/base or whatsnew/base) so that means empty description in this case.
Which leads me to adding
{% block page_desc %}{{ ftl('whatsnew-page-description') }}{% endblock %}
to the whatsnew/base should actually fix both the meta and og descriptions for all WNPs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good suggestion. I think initially when these templates were started we had a different description for each page but somewhere along the way stopped doing that and it's been the same ever since. I'll do a follow-up PR to update the base template(s).