Add WNP128 for Firefox

[reemhamz]

One-line summary

Adds the Whats New page v128 for Firefox, for both NA and E
Launch date: July 9th 2024

Brief doc

Significant changes and points to review

• Added WNP for NA and EU
• NA will have the PiP page and a Nimbus test page
• EU will have 3 variations:
  • Add-ons page (UK, DE, FR, IT, ES, PL locales) (VERSION A)
  • 2 MoFo donation pages (UK, DE, FR only) (VERSION B & C)
• We are no longer getting analytics from EU WNPs, so there won't be an analytics JS file for EU
• Added a new MoFo donation CTA to the bottom of the WNPs going forward (plus legacy WNP)

Issue / Bugzilla link

Fixes #14713

Testing

Local testing

NA

• http://localhost:8000/en-US/firefox/128.0/whatsnew/
• http://localhost:8000/en-US/firefox/128.0/whatsnew/?branch=experiment-wnp-128-na-pip&variant=v1 (Nimbus test)
• http://localhost:8000/firefox/110.0/whatsnew/ (added MoFo donate button in legacy WNPs)

EU

Version A: Add-ons (UK, DE, FR, IT, ES, PL)

• http://localhost:8000/en-GB/firefox/128.0/whatsnew/?v=1
• http://localhost:8000/de/firefox/128.0/whatsnew/?v=1
• http://localhost:8000/fr/firefox/128.0/whatsnew/?v=1
• http://localhost:8000/it/firefox/128.0/whatsnew/?v=1
• http://localhost:8000/es-ES/firefox/128.0/whatsnew/?v=1
• http://localhost:8000/pl/firefox/128.0/whatsnew/?v=1

Version B: Donate [Fx angle] (UK, DE, FR)

• http://localhost:8000/en-GB/firefox/128.0/whatsnew/?v=2
• http://localhost:8000/de/firefox/128.0/whatsnew/?v=2
• http://localhost:8000/fr/firefox/128.0/whatsnew/?v=2

Version C: Donate [MoFo angle] (UK, DE, FR)

• http://localhost:8000/en-GB/firefox/128.0/whatsnew/?v=3
• http://localhost:8000/de/firefox/128.0/whatsnew/?v=3
• http://localhost:8000/fr/firefox/128.0/whatsnew/?v=3

Demo servers

NA

• https://www-demo5.allizom.org/en-US/firefox/128.0/whatsnew/
• https://www-demo5.allizom.org/en-US/firefox/128.0/whatsnew/?branch=experiment-wnp-128-na-pip&variant=v1 (Nimbus test)
• https://www-demo5.allizom.org/firefox/110.0/whatsnew/ (added MoFo donate button in legacy WNPs)

EU

Version A: Add-ons (UK, DE, FR, IT, ES, PL)

• https://www-demo5.allizom.org/en-GB/firefox/128.0/whatsnew/?v=1
• https://www-demo5.allizom.org/de/firefox/128.0/whatsnew/?v=1
• https://www-demo5.allizom.org/fr/firefox/128.0/whatsnew/?v=1
• https://www-demo5.allizom.org/it/firefox/128.0/whatsnew/?v=1
• https://www-demo5.allizom.org/es-ES/firefox/128.0/whatsnew/?v=1
• https://www-demo5.allizom.org/pl/firefox/128.0/whatsnew/?v=1

Version B: Donate [Fx angle] (UK, DE, FR)

• https://www-demo5.allizom.org/en-GB/firefox/128.0/whatsnew/?v=2
• https://www-demo5.allizom.org/de/firefox/128.0/whatsnew/?v=2
• https://www-demo5.allizom.org/fr/firefox/128.0/whatsnew/?v=2

Version C: Donate [MoFo angle] (UK, DE, FR)

• https://www-demo5.allizom.org/en-GB/firefox/128.0/whatsnew/?v=3
• https://www-demo5.allizom.org/de/firefox/128.0/whatsnew/?v=3
• https://www-demo5.allizom.org/fr/firefox/128.0/whatsnew/?v=3

[codecov]

Codecov Report

Attention: Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 77.18%. Comparing base (49da8c3) to head (3f70d0a).
Report is 9 commits behind head on main.

Files	Patch %	Lines
bedrock/firefox/views.py	65.00%	7 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14720      +/-   ##
==========================================
+ Coverage   77.16%   77.18%   +0.01%     
==========================================
  Files         159      159              
  Lines        8203     8239      +36     
==========================================
+ Hits         6330     6359      +29     
- Misses       1873     1880       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[craigcook]

Looks good, mostly just some odds and ends that can be cleaned up. Nice work!

[janbrasna]

I think there might be one fluent issue now, otherwise just random nits & bits;)

[janbrasna]

Suggestion: Would this be better in whatsnew/base to just set and forget?

(or another base template for that matter — i silently expected the og:description being set to the same as meta description tbh…)

[janbrasna]

OK, og sets self.page_desc():

bedrock/bedrock/base/templates/base-protocol.html

Line 39 in 2656cbd

<meta property="og:description" content="{% filter striptags %}{% block page_og_desc %}{{ self.page_desc() }}{% endblock %}{% endfilter %}">

& meta leaves to the page_desc block:

bedrock/bedrock/base/templates/base-protocol.html

Line 32 in 2656cbd

<meta name="description" content="{% filter striptags %}{% block page_desc %}{% endblock %}{% endfilter %}">

that is never set further (firefox/base or whatsnew/base) so that means empty description in this case.

Which leads me to adding {% block page_desc %}{{ ftl('whatsnew-page-description') }}{% endblock %} to the whatsnew/base should actually fix both the meta and og descriptions for all WNPs.

[craigcook]

This is a good suggestion. I think initially when these templates were started we had a different description for each page but somewhere along the way stopped doing that and it's been the same ever since. I'll do a follow-up PR to update the base template(s).

[janbrasna]

BTW I'm not sure how well the image+text renders for you, I'm having better results with additional e.g. line-height: 2 aligning it better inside the button.