Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove overdue obsolete strings #14822

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Conversation

reemhamz
Copy link
Contributor

@reemhamz reemhamz commented Jul 15, 2024

One-line summary

Removing overdue obsolete strings from some Fluent files.

Note

I went ahead and removed an obsolete string expiring on July 22nd 2024, so we can have this PR merge on the 22nd

Issue

Fixes #14820

Testing

@reemhamz reemhamz added Do Not Merge ⚠️ Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less and removed Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Jul 15, 2024
@reemhamz reemhamz changed the title Remove May/June/July obsolete strings Remove overdue obsolete strings Jul 15, 2024
@reemhamz reemhamz added the WIP 🚧 Pull request is still work in progress label Jul 15, 2024
@reemhamz reemhamz marked this pull request as draft July 15, 2024 07:06
@reemhamz reemhamz force-pushed the remove-obsolete-strings-july2024 branch 2 times, most recently from 8aa6b1d to ad339f1 Compare July 15, 2024 07:46
@reemhamz reemhamz added Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour and removed WIP 🚧 Pull request is still work in progress labels Jul 15, 2024
@reemhamz reemhamz marked this pull request as ready for review July 15, 2024 07:48
@reemhamz reemhamz force-pushed the remove-obsolete-strings-july2024 branch from ad339f1 to 97157a2 Compare July 16, 2024 01:04
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.37%. Comparing base (7eb7585) to head (c3a8bd7).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14822      +/-   ##
==========================================
+ Coverage   77.29%   77.37%   +0.08%     
==========================================
  Files         160      161       +1     
  Lines        8281     8302      +21     
==========================================
+ Hits         6401     6424      +23     
+ Misses       1880     1878       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reemhamz reemhamz marked this pull request as draft July 16, 2024 07:32
@reemhamz reemhamz force-pushed the remove-obsolete-strings-july2024 branch from 8cbbb94 to 97157a2 Compare July 16, 2024 07:32
@reemhamz reemhamz marked this pull request as ready for review July 16, 2024 07:36
Copy link
Contributor

@janbrasna janbrasna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow what a cleanup job, thanks for taking a stab at this!

I'm adding a few more obsoletes that kinda never ended up being marked as obsolete: 😇

bedrock/mozorg/templates/mozorg/about/index.html Outdated Show resolved Hide resolved
l10n/en/mozorg/about.ftl Outdated Show resolved Hide resolved
l10n/en/firefox/more.ftl Outdated Show resolved Hide resolved
l10n/en/firefox/more.ftl Outdated Show resolved Hide resolved
l10n/en/navigation.ftl Outdated Show resolved Hide resolved
Comment on lines 19 to 20
navigation-firefox-browsers-put = { -brand-name-firefox } browsers put your privacy first — and always have.
navigation-take-the-passwords-youve = Take the passwords you’ve saved in { -brand-name-firefox } with you everywhere.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are gone too… FireTV, VR goggles, lockwise… isn't most of the v1 navigation gone already? (I see only bits like the navigation-firefox-blog at the end here being used as a fallback for navigation-v2-firefox-blog e.g., but otherwise this is probably all obsolete kinda implicitly, being removed at some point via nav redesign…)

Copy link
Contributor Author

@reemhamz reemhamz Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I just noticed that too. I think I'll create a separate issue for this so this PR doesn't get too large!

Edit: created #14848!

Comment on lines 9 to 14
{% extends "firefox/whatsnew/base.html" %}

{% block page_title %}{{ ftl('whatsnew-page-title') }}{% endblock %}
{% block page_title %}{{ ftl('whatsnew-page-title-v2') }}{% endblock %}

{#- This will appear as <meta property="og:description"> which can be used for social share -#}
{% block page_og_desc %}{{ ftl('whatsnew-page-description') }}{% endblock %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be easier to manage if all these titles + descriptions from all the wnp templates were moved to whatsnew/base?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw Craig's suggestion --
@craigcook is this still something you're hoping to work on?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I forgot about that almost as soon as I posted it... but we've been talking about redoing the base WNP templates for some time and it just keeps getting put off for other work. I do think at the very least we can add the title string to the base file, that doesn't have to wait. If you want to do it as part of this PR that seems sensible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will be doing some light housekeeping in wnps, welcomes and subnavs soon~ish, so you can leave it like this and i'll pick it up later, possibly together with the v1 nav obsoletes…

(Just wanted to confirm it'd be a welcome change…)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a welcome change, thanks Jan!

Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ ✂️

@stephaniehobson stephaniehobson merged commit 4af4e4d into main Jul 25, 2024
6 checks passed
@stephaniehobson stephaniehobson deleted the remove-obsolete-strings-july2024 branch July 25, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Awaiting code review Review: S Code review time: 30 mins to 1 hour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bot] Remove obsolete l10n strings and ftl files
4 participants