-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and code to remove GA3 references and match GA4 reality #14910
base: main
Are you sure you want to change the base?
Conversation
d8ede47
to
242f61b
Compare
@@ -19,7 +19,7 @@ | |||
class_name='mzp-t-product mzp-t-secondary mzp-t-md', | |||
optional_attributes= { | |||
'data-cta-text' : 'Get Mozilla VPN', | |||
'data-cta-type' : 'button', | |||
'data-cta-type' : 'vpn', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This links to a page on WMO and so should not have the fxa-
prefix other cta-types have (true for all occurrences of vpn_product_referral_link
)
2f33c6a
to
0149529
Compare
Note to self: add docs about stub attribution needing data-download-version |
437863c
to
9ef2ff3
Compare
4562671
to
34d1a09
Compare
@@ -8,6 +8,8 @@ | |||
Firefox desktop attribution | |||
=========================== | |||
|
|||
TODO: add something about `data-download-version` being checked to apened stub attribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this needs to be done, I'd like to get the other changes merged before it gets too stale if it's okay to merge a todo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we leave this for another PR?
There seem to be quite some conflicts, so a rebase is in order! Once that's done I can get to reviewing this :) |
12793a2
to
e6306eb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14910 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 163 163
Lines 8480 8480
=======================================
Hits 6605 6605
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
Rebased! |
36ede89
to
beffdaf
Compare
Update analytics documentation to remove UA and edit the code to make it match the GA4 docs. - Re-write analytics documentation intro - Remove: UA documentation - Remove: UA dataLayer pushes - Remove: data-link-group (migrate into data-link-position where appropriate) - Remove: data-cta-type="button" - Remove: data-cta-type="link" - data-cta and data-link should not be used on the same attribute
beffdaf
to
6b002f5
Compare
Rebased again! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whewwwww, this was a big one.
💡 Note that this needs another rebase
Good job working so diligently on this! I left some important questions and suggestions, however I'm also still finding instances of data-cta-type="b utton"
, data-cta-type="link"
, and data-link-group
in the code in the code that should be addressed:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: You mentioned in the PR info that we're removing data-link-group
and (if appropriate) replacing it with data-link-position
, but I see both of those attributes on this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Same as above, I see both data-link-group
with data-link-position
in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-link-group
with data-link-position
in this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file isn't being used anywhere?
does not allow for the injection of custom HTML or JavaScript but all tags use | ||
built in templates to minimize any chance of introducing a bug into Bedrock. | ||
Google calls a 3rd party JavaScript library that is imported by adding a script tag to a website, | ||
Google names these "tag"s. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Google names these "tag"s. | |
Google names these "tags". |
action: 'clickthrough', | ||
name: '<banner name>', //ex. Fb-Video-Compat | ||
}); | ||
Some form submissions are also being collected but newsletter signups are not. `(See Bug #13348)`_ They are instead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some form submissions are also being collected but newsletter signups are not. `(See Bug #13348)`_ They are instead | |
Some form submissions are also being collected but newsletter signups are not `(see bug #13348)`_ . They are instead |
variant: 'campaign-page', | ||
}); | ||
} | ||
The attribute ``data-cta-text`` must be present to trigger the event. All links to accounts.firefox.com must also use cta-type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attribute ``data-cta-text`` must be present to trigger the event. All links to accounts.firefox.com must also use cta-type. | |
The attribute ``data-cta-text`` must be present to trigger the event. All links to accounts.mozilla.com must also use ``datacta-type`` . |
+-----------------------+------------------------------------------------------------------------------------------------+ | ||
| Data Attribute | Expected Value | | ||
+=======================+================================================================================================+ | ||
| ``data-link-text`` * | Text or name of the link (e.g. ``Monitor``, ``Features``, ``Instagram (mozilla)``, | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What is this asterisks referring to?
+-----------------------+----------------------------------------------------------------------------------+ | ||
| Data Attribute | Expected Value | | ||
+=======================+==================================================================================+ | ||
| ``data-cta-text`` * | Text or name of the link (e.g. ``Sign Up``, ``Start Here``, ``Get Relay``, | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: What is this asterisks referring to?
@@ -8,6 +8,8 @@ | |||
Firefox desktop attribution | |||
=========================== | |||
|
|||
TODO: add something about `data-download-version` being checked to apened stub attribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So should we leave this for another PR?
One-line summary
Update analytics documentation to only reference GA4 and edit the code to make it match the GA4 docs.
Significant changes and points to review
Issue / Bugzilla link
#13951
#14053
#14054
Testing
I know there's a lot of changes but most of them are simple edits. Hopefully this isn't too onerous!