Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L10n fixes #15033

Merged
merged 1 commit into from
Sep 3, 2024
Merged

L10n fixes #15033

merged 1 commit into from
Sep 3, 2024

Conversation

stephaniehobson
Copy link
Contributor

@stephaniehobson stephaniehobson marked this pull request as ready for review August 29, 2024 22:40
@stephaniehobson stephaniehobson mentioned this pull request Aug 29, 2024
Merged
@stephaniehobson stephaniehobson added Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less labels Aug 30, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.70%. Comparing base (fd88ba6) to head (4f7ce04).
Report is 12 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #15033   +/-   ##
=======================================
  Coverage   77.70%   77.70%           
=======================================
  Files         161      161           
  Lines        8378     8380    +2     
=======================================
+ Hits         6510     6512    +2     
  Misses       1868     1868

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephaniehobson stephaniehobson added the Frontend HTML, CSS, JS... client side stuff label Aug 30, 2024
@reemhamz reemhamz self-assigned this Sep 3, 2024
reemhamz
reemhamz approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@reemhamz reemhamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ 🏓

@reemhamz reemhamz merged commit bbb15d0 into main Sep 3, 2024
8 checks passed
@reemhamz reemhamz deleted the l10n-fix branch September 3, 2024 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reemhamz reemhamz reemhamz approved these changes

Assignees

@reemhamz reemhamz

Labels
Frontend HTML, CSS, JS... client side stuff Needs Review Awaiting code review Review: µ Code review time: 5 minutes or less
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephaniehobson @reemhamz