Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new vs. old logo sizing #15130

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

janbrasna
Copy link
Contributor

@janbrasna janbrasna commented Sep 12, 2024

One-line summary

Fixes old logo sizing regression in md+ breakpoints.

Significant changes and points to review

Only targets new logo class for sizing tweaks.

Issue / Bugzilla link

Fixes #15128

Testing

http://localhost:8000/en-US/
http://localhost:8000/de/

echo "SWITCH_M24_LOGO=off" >> .env

http://localhost:8000/en-US/
http://localhost:8000/de/

@stephaniehobson stephaniehobson added P1 First level priority - Must have Review: XS Code review time: up to 30min Refresh 🦖 Work related to the 2024 site refresh labels Sep 12, 2024
@janbrasna janbrasna marked this pull request as ready for review September 12, 2024 21:22
Copy link
Contributor

@stephaniehobson stephaniehobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+ 🤦‍♀️

@stephaniehobson stephaniehobson merged commit a8f69d1 into mozilla:main Sep 12, 2024
5 checks passed
@stephaniehobson
Copy link
Contributor

@janbrasna thank you!

@janbrasna janbrasna deleted the fix/m24-logo-selector branch September 12, 2024 21:28
@janbrasna
Copy link
Contributor Author

@stephaniehobson Anytime. I only wish I wouldn't have to fix up my own fixups though, maybe next time… 🤷 This time around, a followup: #15177 (Sorry.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 First level priority - Must have Refresh 🦖 Work related to the 2024 site refresh Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly sized Mozilla logo in the (old) nav
2 participants