Fix new logo sizing in base-error #15177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janbrasna
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Skips targeting base-error template uses for sizing adjustments of m24-logo.
Significant changes and points to review
404/500 error pages use
.header-image .logo-mozilla .c-navigation-logo-imagewhile elsewhere it's.c-navigation-logo .c-navigation-logo-image— so this specific selector only targets the old nav, leaving the sizing in base-error header just to the img attrs.(It could be fine-tuned a bit more though, but that is perhaps to come after cleaning up the outdated variants one day.)
Issue / Bugzilla link
#15130 followup
Testing
http://localhost:8000/nl/foo404 (with Debug=False)