Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: Add CTA pencil banner #15133

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refresh: Add CTA pencil banner #15133

wants to merge 1 commit into from

Conversation

reemhamz
Copy link
Contributor

@reemhamz reemhamz commented Sep 13, 2024

One-line summary

This pencil banner, which is to be added to all the pages that'll be using the new navigation (#14966), will be replacing the nav CTAs we currently have on www.mozilla.org.

This is currently a WIP 'til the new nav PR gets merged. The placements of files and imports will be updated and refined then, as well. For now, I just did what I could to get the banner showing, which will hopefully reduce whatever integration we need to get done until the new nav descends upon us ✨

Note

Copy for the Firefox pencil banner is currently just placeholder

Issue / Bugzilla link

#15095

Testing

Make sure your .env file has the following:

SWITCH_M24_HOME=True
SWITCH_M24_ABOUT=True

http://localhost:8000/en-US/

@reemhamz reemhamz added WIP 🚧 Pull request is still work in progress Frontend HTML, CSS, JS... client side stuff labels Sep 13, 2024
@reemhamz reemhamz marked this pull request as draft September 13, 2024 05:17
@reemhamz reemhamz added Review: XS Code review time: up to 30min Needs Review Awaiting code review and removed WIP 🚧 Pull request is still work in progress labels Sep 19, 2024
@reemhamz reemhamz marked this pull request as ready for review September 19, 2024 00:01
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (c7bf500) to head (4d86113).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15133      +/-   ##
==========================================
+ Coverage   77.83%   77.88%   +0.04%     
==========================================
  Files         162      162              
  Lines        8459     8473      +14     
==========================================
+ Hits         6584     6599      +15     
+ Misses       1875     1874       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reemhamz reemhamz removed the Needs Review Awaiting code review label Sep 24, 2024
@reemhamz reemhamz marked this pull request as draft September 24, 2024 03:33
@reemhamz
Copy link
Contributor Author

Converting this back to a draft since work on this is paused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend HTML, CSS, JS... client side stuff Review: XS Code review time: up to 30min
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant