Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh: Add CTA pencil banner #15133

Closed
wants to merge 72 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
4d86113
add pencil banner
reemhamz Sep 13, 2024
f88e915
Bump babel-loader from 9.1.3 to 9.2.1 in the frontend group
dependabot[bot] Sep 17, 2024
282dd25
Use sentence case for navigation headings and titles
alexgibson Sep 17, 2024
9dd7996
Refresh: update brand fonts globally [fix #15088] (#15144)
craigcook Sep 17, 2024
3c52d41
Also send reports for the enforced CSP
robhudson Sep 17, 2024
c7b5e74
Remove new brand assets from trademarks list [#15091] (#15174)
craigcook Sep 18, 2024
d4bc3dd
Add WNP 131 (Fixes #15097) (#15176)
alexgibson Sep 18, 2024
dbcdc38
Allow the url() helper to get a path for a page that will only exist …
stevejalim Sep 19, 2024
70e7bf3
Remove Pocket mode functional tests
alexgibson Sep 19, 2024
fd729dd
fix issue #15154
wen-2018 Sep 17, 2024
f1c614a
Update nav logo refresh
janbrasna Sep 17, 2024
143c1ec
Update nightly firstrun QA CTA link
janbrasna Sep 19, 2024
b8eecbf
More updates to trademarks page [#15091] (#15190)
craigcook Sep 20, 2024
3fc7821
Updates to adblocker feature page [fix #15104] (#15189)
craigcook Sep 20, 2024
2523dbe
Misc a11y fixes (#15186)
alexgibson Sep 20, 2024
603c889
Nav bug fix (#15171)
wen-2018 Sep 20, 2024
b4ae91a
Update to Python 3.12.x
robhudson Sep 16, 2024
19466ac
Run `pyupgrade --py312-plus **/*.py`
robhudson Sep 16, 2024
b990a19
String fix for adblocker page [#15104] (#15199)
craigcook Sep 20, 2024
77f26cc
Exclude django_admin_log table from sqlite export to avoid integrity …
stevejalim Sep 23, 2024
cbeb0d3
Bump send and express
dependabot[bot] Sep 23, 2024
8c32aa7
Add custom app store links to built-for-you page (Fixes #15203) (#15204)
alexgibson Sep 23, 2024
92bfcc3
Fix footer-refresh ftl href var
janbrasna Sep 17, 2024
70e1b35
Update footer-refresh cc link href
janbrasna Sep 17, 2024
4617fef
Fix the example of the rendition spec in the CMS docs (#15213)
stevejalim Sep 24, 2024
1fe81b8
Add Swedish to translate feature list (#15216)
janbrasna Sep 26, 2024
dc3154f
Fix DB export script (#15220)
stevejalim Sep 26, 2024
1a118aa
Issue #15187 - Nightly update message should refer to Firefox Labs in…
pascalchevrel Sep 26, 2024
bc49d86
update top margin for pages with sub nav fixes issue #15214 (#15215)
wen-2018 Sep 27, 2024
1798f1f
Migrate remaining VPN Selenium tests to Playwright (#14904)
alexgibson Sep 30, 2024
b091afe
Update CMS image-download script to make the appropriate expected tar…
stevejalim Sep 30, 2024
751444b
Ensure CMS image downloader makes any missing dirs before download
stevejalim Sep 30, 2024
c568fe0
When redownloading images, ensure that renditions are recreated
stevejalim Sep 30, 2024
4b0a27b
Decommission old /leadership page template (Fixes #15135) (#15183)
alexgibson Oct 1, 2024
ae405e4
Bump @playwright/test in /tests/playwright in the playwright group
dependabot[bot] Oct 1, 2024
f8b5c0d
Bump the frontend group with 5 updates
dependabot[bot] Oct 1, 2024
e8b1055
Add newsletter form to nothing-personal page (Fixes #15218) (#15223)
alexgibson Oct 1, 2024
7e3b4bb
Add new Mozilla advertising pages [fix #15198] (#15228)
craigcook Oct 1, 2024
6b31773
Update nothing personal college interest as waitlist
robhudson Oct 1, 2024
8c90fb8
Run end-of-file-fixer on all files
robhudson Sep 17, 2024
e16932b
Update Makefile to check for `uv pip`
robhudson Sep 18, 2024
027ebb2
Show custom WNP 131 when no experiment params are present (#15237)
alexgibson Oct 2, 2024
a646ab7
Import config waffles to django waffles 🧇
robhudson Sep 19, 2024
2a042dc
Remove mozilla.social links and invite page (#15234)
craigcook Oct 2, 2024
3770d8a
Move waffle switches to django-waffle 🧇
robhudson Oct 1, 2024
87fff96
Update waffle switch docs
robhudson Oct 2, 2024
1eeed26
Run docs through `blacken-docs`
robhudson Oct 2, 2024
9d502a4
Add note about switch in request/response cycle
robhudson Oct 2, 2024
38744da
Fix WNP 131 CTA for default custom template
alexgibson Oct 3, 2024
437b307
Fix app store url examples in the docs (#15244)
alexgibson Oct 7, 2024
ac33bc8
Bump @sentry/browser from 8.32.0 to 8.33.0
dependabot[bot] Oct 3, 2024
49e77bd
Decommission old VPN landing page template (Fixes #15226) (#15243)
alexgibson Oct 7, 2024
90d7c15
Ignore non-useful JS error in Sentry
alexgibson Oct 7, 2024
aebe23e
Moments page for Root Certification expiration (1 of 6) (#15212)
reemhamz Oct 7, 2024
c8d7a67
Add switches to healthz-cron
robhudson Oct 7, 2024
31e31af
Update docs and code to remove GA3 references and match GA4 reality (…
stephaniehobson Oct 8, 2024
0c59289
Decommission old VPN platform pages (Fixes #15245) (#15249)
alexgibson Oct 8, 2024
1270bcc
Restore missing VPN shared string (Fixes #15257)
alexgibson Oct 8, 2024
ae71e0a
Stop changing VPN nav CTA button color (Fixes #15250) (#15256)
alexgibson Oct 8, 2024
573401c
Bump Python dependencies
robhudson Oct 3, 2024
ef13498
More bumps to stay fresh
robhudson Oct 7, 2024
4cff07d
Remove linter_config brand exclusions
janbrasna Aug 23, 2024
97633e7
Update bug writing guidelines link on /contact page (Fixes bug 1923262)
alexgibson Oct 8, 2024
06dd27f
Prevent aria-hidden elements from receiving keyboard focus (Fixes #15…
alexgibson Oct 8, 2024
939cc64
Update protocol-firefox m24-logo sizing
janbrasna Sep 22, 2024
926c5be
add 2024 h1 transparency report (fixes #15239) (#15241)
reemhamz Oct 8, 2024
ee69a70
Added ESR link and updated primary link in Moments Page (#15260)
reemhamz Oct 9, 2024
5a6bc3d
Shift wagtail menus to regular `MenuItem`s
robhudson Oct 7, 2024
92087cb
Update markupsafe to fix CSRF errors
robhudson Oct 9, 2024
9fa4b57
Remove superfluous templates (Fixes #15263) (#15264)
alexgibson Oct 9, 2024
04011a3
Simplify WNP templates (#14936)
janbrasna Oct 9, 2024
c4e115c
removed Download Firefox logic
reemhamz Oct 10, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
4 changes: 1 addition & 3 deletions .github/l10n/linter_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ CO01:
- "{ -brand-name-mozilla } account"
exclusions:
files: []
messages:
# firefox/features/translate.ftl
- features-translate-for-everyone
messages: []
2 changes: 1 addition & 1 deletion .github/workflows/fluent_linter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Set up Python 3
uses: actions/setup-python@v5
with:
python-version: "3.11"
python-version: "3.12"
- name: Install Python dependencies
run: |
pip install moz-fluent-linter==0.4.*
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull_request_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: "3.11" # matches current Python in production
python-version: "3.12" # matches current Python in production
- name: "Run Python tests (on Docker)"
run: |
make clean test-image
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ repos:
- --comment-style
- "|#|"
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.6.3
rev: v0.6.9
hooks:
- id: ruff
- id: ruff-format
Expand Down
2 changes: 1 addition & 1 deletion .readthedocs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ version: 2
build:
os: ubuntu-20.04
tools:
python: "3.11"
python: "3.12"

# Build documentation in the docs/ directory with Sphinx
sphinx:
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
########
# Python dependencies builder
#
FROM python:3.11-slim-bookworm AS python-builder
FROM python:3.12-slim-bookworm AS python-builder

WORKDIR /app
ENV LANG=C.UTF-8
Expand Down Expand Up @@ -52,7 +52,7 @@ RUN npm run build --verbose
########
# django app container
#
FROM python:3.11-slim-bookworm AS app-base
FROM python:3.12-slim-bookworm AS app-base

# Extra python env
ENV PYTHONDONTWRITEBYTECODE=1
Expand Down
15 changes: 11 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ DOCKER = $(shell which docker)
TEST_DOMAIN = www.mozilla.org
POCKET_MODE = Pocket

# Check if 'uv' exists and set the command accordingly
ifneq (, $(shell which uv 2>/dev/null))
pip = uv pip
else
pip = pip
endif

all: help

help:
Expand Down Expand Up @@ -164,7 +171,7 @@ compile-requirements: .docker-build-pull
${DC} run --rm compile-requirements

check-requirements: .docker-build-pull
${DC} run --rm test pip list -o
${DC} run --rm app ./bin/check-pinned-requirements.py

######################################################
# For use in local-machine development (not in Docker)
Expand All @@ -184,8 +191,8 @@ install-local-python-deps:
# Dev requirements are a superset of prod requirements, but we install
# them in the same separate steps that we use for our Docker-based build,
# so that it mirrors Production and Dev image building
pip install -r requirements/prod.txt
pip install -r requirements/dev.txt
$(pip) install -r requirements/prod.txt
$(pip) install -r requirements/dev.txt

run-local-task-queue:
# We temporarily source the .env for the command's duration only
Expand All @@ -195,7 +202,7 @@ run-local-task-queue:


clean-local-deps:
pip uninstall mdx_outline -y && pip freeze | xargs pip uninstall -y
$(pip) uninstall mdx_outline -y && $(pip) freeze | xargs $(pip) uninstall -y

# Done explicitly to avoid surprises
install-custom-git-hooks:
Expand Down
29 changes: 29 additions & 0 deletions bedrock/base/management/commands/import_waffle_switches.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this
# file, You can obtain one at https://mozilla.org/MPL/2.0/.

from django.core.management.base import BaseCommand

from waffle.models import Switch

from bedrock.base.models import ConfigValue
from bedrock.utils.management.decorators import alert_sentry_on_exception


@alert_sentry_on_exception
class Command(BaseCommand):
def handle(self, *args, **options):
prefix = "SWITCH_"

for config in ConfigValue.objects.all():
# Ignore funnelcakes and other yummy things.
if not config.name.startswith(prefix):
continue

# Remove prefix.
name = config.name[len(prefix) :]
# Set active to boolean.
active = config.value == "on"

switch, created = Switch.objects.update_or_create(name=name, defaults={"active": active})
print(f"{'Created new' if created else 'Updated'} switch: {name} = {'on' if active else 'off'}")
131 changes: 0 additions & 131 deletions bedrock/base/management/commands/update_www_config.py

This file was deleted.

4 changes: 0 additions & 4 deletions bedrock/base/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,3 @@ class Meta:

def __str__(self):
return f"{self.name}={self.value}"


def get_config_dict():
return {c.name: c.value for c in ConfigValue.objects.all()}
6 changes: 5 additions & 1 deletion bedrock/base/templates/base-protocol-mozilla.html
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,11 @@
{% block body_class %}mzp-t-mozilla{% endblock %}

{% block site_css %}
{{ css_bundle('protocol-mozilla') }}
{% if switch('m24-global-styles') %}
{{ css_bundle('protocol-mozilla-2024') }}
{% else %}
{{ css_bundle('protocol-mozilla') }}
{% endif %}
{% if switch('m24-navigation-and-footer') and LANG.startswith('en-') %}
{{ css_bundle('m24-navigation-and-footer') }}
{% endif %}
Expand Down
6 changes: 5 additions & 1 deletion bedrock/base/templates/base-protocol.html
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,11 @@
<!--[if !IE]><!-->
{# Global styles, hidden from IE9 and lower #}
{% block site_css %}
{{ css_bundle('protocol-firefox') }}
{% if switch('m24-global-styles') %}
{{ css_bundle('protocol-mozilla-2024') }}
{% else %}
{{ css_bundle('protocol-firefox') }}
{% endif %}
{% if switch('m24-navigation-and-footer') and LANG.startswith('en-') %}
{{ css_bundle('m24-navigation-and-footer') }}
{% endif %}
Expand Down
23 changes: 23 additions & 0 deletions bedrock/base/templates/cron-health-check.html
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,28 @@ <h1 id="git-repos">External Git Repos</h1>
{% endfor %}
</tbody>
</table>

<h1 id="waffle-switches">Waffle Switches</h1>
<table>
<thead>
<tr>
<th>Name</th>
<th>Active</th>
</tr>
</thead>
<tbody>
{% for switch in switches %}
<tr>
<td>{{ switch.name }}</td>
<td>{% if switch.active %}✅{% else %}❌{% endif %}</td>
</tr>
{% else %}
<tr>
<td colspan="2">No switches found</td>
</tr>
{% endfor %}
</tbody>
</table>

</body>
</html>
Loading