Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile to check for uv pip #15178

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Update Makefile to check for uv pip #15178

merged 1 commit into from
Oct 2, 2024

Conversation

robhudson
Copy link
Member

One-line summary

If uv pip, use it, otherwise fall back to pip. This also pulls in the check-pinned-requirements.py instead of raw pip list.

  • I used an AI to write some of this code.

AI helped spit out a skeleton of the check-pinned-requirements.py file and I further honed it.

@robhudson robhudson added the Backend Server stuff yo label Sep 18, 2024
Copy link
Collaborator

@stevejalim stevejalim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

Sorry for the late review. Originally I wasn't sure enough of context and was short on headspace, but I've got my head around it now. This looks cool and should speed things up nicely in general.

@robhudson robhudson merged commit fc18c5f into main Oct 2, 2024
5 checks passed
@robhudson robhudson deleted the test-uv-pip branch October 2, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Server stuff yo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants