Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Makefile to check for uv pip #15178

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Update Makefile to check for uv pip #15178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,13 @@ DOCKER = $(shell which docker)
TEST_DOMAIN = www.mozilla.org
POCKET_MODE = Pocket

# Check if 'uv' exists and set the command accordingly
ifneq (, $(shell which uv 2>/dev/null))
pip = uv pip
else
pip = pip
endif

all: help

help:
Expand Down Expand Up @@ -164,7 +171,7 @@ compile-requirements: .docker-build-pull
${DC} run --rm compile-requirements

check-requirements: .docker-build-pull
${DC} run --rm test pip list -o
${DC} run --rm app ./bin/check-pinned-requirements.py

######################################################
# For use in local-machine development (not in Docker)
Expand All @@ -184,8 +191,8 @@ install-local-python-deps:
# Dev requirements are a superset of prod requirements, but we install
# them in the same separate steps that we use for our Docker-based build,
# so that it mirrors Production and Dev image building
pip install -r requirements/prod.txt
pip install -r requirements/dev.txt
$(pip) install -r requirements/prod.txt
$(pip) install -r requirements/dev.txt

run-local-task-queue:
# We temporarily source the .env for the command's duration only
Expand All @@ -195,7 +202,7 @@ run-local-task-queue:


clean-local-deps:
pip uninstall mdx_outline -y && pip freeze | xargs pip uninstall -y
$(pip) uninstall mdx_outline -y && $(pip) freeze | xargs $(pip) uninstall -y

# Done explicitly to avoid surprises
install-custom-git-hooks:
Expand Down