Issue #15187 - Nightly update message should refer to Firefox Labs instead of Nightly Experiments #15219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Labs instead of Nightly Experiments - Create a new string for the page with id nightly-whatsnew-want-to-know-which-v3 - Add a new -brand-name-firefox-labs string for Firefox Labs in brands.ftl
pascalchevrel
force-pushed
the
whatsnew_nightly_update
branch
from
ad790ac
to
e60c142
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15219 +/- ##
=======================================
Coverage 77.88% 77.88%
=======================================
Files 163 163
Lines 8480 8480
=======================================
Hits 6605 6605
Misses 1875 1875 ☔ View full report in Codecov by Sentry. |
alexgibson
requested changes
Sep 26, 2024
| @@ -65,7 +65,7 @@ <h4 class="mzp-c-callout-title">¿Quieres ayudar en España?</h4> | |||
|
|
|||
| <p> | |||
| {% set attrs = 'href="#" class="nightly-experiments-link"' %} | |||
| {{ ftl('nightly-whatsnew-want-to-know-which-v2', attrs=attrs) }} | |||
| {{ ftl('nightly-whatsnew-want-to-know-which-v3', attrs=attrs) }} | |||
There was a problem hiding this comment.
We should fall back to the old string for locales that have not yet updated
Suggested change
| {{ ftl('nightly-whatsnew-want-to-know-which-v3', attrs=attrs) }} | |
| {{ ftl('nightly-whatsnew-want-to-know-which-v3', fallback='nightly-whatsnew-want-to-know-which-v2', attrs=attrs) }} |
| @@ -25,6 +25,7 @@ nightly-whatsnew-if-you-want-to-v3 = If you want to know what’s happening arou | |||
| # Variables: | |||
| # $attrs (string) - link href and additional attributes | |||
| nightly-whatsnew-want-to-know-which-v2 = Want to know which platform features you could test on { -brand-name-nightly } and can’t see yet on other { -brand-name-firefox } channels? Then have a look at the <a { $attrs }>Nightly Experiments</a> preferences page. | |||
| nightly-whatsnew-want-to-know-which-v3 = Want to know which platform features you could test on { -brand-name-nightly } and can’t see yet on other { -brand-name-firefox } channels? Then have a look at the <a { $attrs }>{ -brand-name-firefox-labs }</a> preferences page. | |||
There was a problem hiding this comment.
This new string needs a comment to explain the variable (you can copy and paste the comment from the v2 string)
| @@ -25,6 +25,7 @@ nightly-whatsnew-if-you-want-to-v3 = If you want to know what’s happening arou | |||
| # Variables: | |||
| # $attrs (string) - link href and additional attributes | |||
| nightly-whatsnew-want-to-know-which-v2 = Want to know which platform features you could test on { -brand-name-nightly } and can’t see yet on other { -brand-name-firefox } channels? Then have a look at the <a { $attrs }>Nightly Experiments</a> preferences page. | |||
There was a problem hiding this comment.
This old string needs to be marked as obsolete so it can be removed in 2 months time. See https://bedrock.readthedocs.io/en/latest/l10n.html#obsolete-strings for details.
- Add l10n comment for new string - Mark old string as the fallback l10n string in the template - Mark old string as being obsolete on 2024-11-26
alexgibson
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nightly-whatsnew-want-to-know-which-v3-brand-name-firefox-labsstring for Firefox Labs in brands.ftlIssue / Bugzilla link
issue #15187
Testing
make testpassed