Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #15187 - Nightly update message should refer to Firefox Labs instead of Nightly Experiments #15219

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Issue #15187 - Nightly update message should refer to Firefox Labs instead of Nightly Experiments #15219

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60c142
Issue #15187 - Nightly update message should refer to Firefox Labs in…
pascalchevrel Sep 26, 2024
bdba72f
Issue #15187 : address code review comments
pascalchevrel Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bedrock/firefox/templates/firefox/nightly/whatsnew.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ <h4 class="mzp-c-callout-title">¿Quieres ayudar en España?</h4>

<p>
{% set attrs = 'href="#" class="nightly-experiments-link"' %}
{{ ftl('nightly-whatsnew-want-to-know-which-v2', attrs=attrs) }}
{{ ftl('nightly-whatsnew-want-to-know-which-v3', attrs=attrs) }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fall back to the old string for locales that have not yet updated

Suggested change
{{ ftl('nightly-whatsnew-want-to-know-which-v3', attrs=attrs) }}
{{ ftl('nightly-whatsnew-want-to-know-which-v3', fallback='nightly-whatsnew-want-to-know-which-v2', attrs=attrs) }}

</p>

<p>{{ ftl('nightly-whatsnew-do-you-experience', bugzilla='https://bugzilla.mozilla.org') }}</p>
Expand Down
4 changes: 4 additions & 0 deletions l10n/en/brands.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@
-brand-name-firefox-private-network = Firefox Private Network
-brand-name-fpn = FPN
## Firefox projects

-brand-name-firefox-labs = Firefox Labs
## Pocket

-brand-name-pocket = Pocket
Expand Down
1 change: 1 addition & 0 deletions l10n/en/firefox/nightly/whatsnew.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ nightly-whatsnew-if-you-want-to-v3 = If you want to know what’s happening arou
# Variables:
# $attrs (string) - link href and additional attributes
nightly-whatsnew-want-to-know-which-v2 = Want to know which platform features you could test on { -brand-name-nightly } and can’t see yet on other { -brand-name-firefox } channels? Then have a look at the <a { $attrs }>Nightly Experiments</a> preferences page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This old string needs to be marked as obsolete so it can be removed in 2 months time. See https://bedrock.readthedocs.io/en/latest/l10n.html#obsolete-strings for details.

nightly-whatsnew-want-to-know-which-v3 = Want to know which platform features you could test on { -brand-name-nightly } and can’t see yet on other { -brand-name-firefox } channels? Then have a look at the <a { $attrs }>{ -brand-name-firefox-labs }</a> preferences page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new string needs a comment to explain the variable (you can copy and paste the comment from the v2 string)


# Variables:
# $bugzilla (url) - link to https://bugzilla.mozilla.org/
Expand Down