-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of unused files (#188) #187
Conversation
================== | ||
|
||
* Extension: Removed the unused CSS files | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to update the history.md manually for each change. We do this via git itself once a new version is about to be released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, I've reverted History.md.
…ns to the Clipboard
This concludes the removal of the unused files and the code clean-up of all the files. |
Could you merge this pull request? |
@UtiluMark I wanted to keep this PR clean and only covering the code removals. All other commits should actually be on a different PR. Can you please fix that? |
Btw. this PR will fix a small part of issue #188. |
@whimboo I've reverted the non-removal/cleanup commits. |
There are still 24 changed files. What I want is the version of the PR you had at first when I reviewed it. I think it would be good if you better get rid of all those extra commits. |
This reverts commit 1081e16.
@whimboo OK, I've reverted everything except the removal of the three unused files. |
That looks fine now. Thanks. I will get the commits squashed and merged to master. |
PR got merged to master as eff8f9e. Now you can create a new PR with all the coding style changes. :) I would suggest that you make use of a new branch in your repository so that you don't destroy your master branch. Thanks again. |
@whimboo I've created PR #189 for one commit UtiluMark@878c788 Removed excessive white space before line endings and fixed indentation by always using spaces and never using tabs. |
Thank you for the other PR. Best would be to simply add a comment on the newly created PR. That one is actually closed. :) |
No description provided.