Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of unused files (#188) #187

Closed
wants to merge 20 commits into from
Closed

Conversation

UtiluMark
Copy link
Contributor

No description provided.

==================

* Extension: Removed the unused CSS files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to update the history.md manually for each change. We do this via git itself once a new version is about to be released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine, I've reverted History.md.

@UtiluMark
Copy link
Contributor Author

This concludes the removal of the unused files and the code clean-up of all the files.

@UtiluMark UtiluMark changed the title Removed the unused CSS files Code optimizations and removal of unused files Sep 28, 2015
@UtiluMark
Copy link
Contributor Author

Could you merge this pull request?

@whimboo
Copy link
Contributor

whimboo commented Sep 29, 2015

@UtiluMark I wanted to keep this PR clean and only covering the code removals. All other commits should actually be on a different PR. Can you please fix that?

@whimboo whimboo changed the title Code optimizations and removal of unused files Removal of unused files (#188) Sep 29, 2015
@whimboo
Copy link
Contributor

whimboo commented Sep 29, 2015

Btw. this PR will fix a small part of issue #188.

@UtiluMark
Copy link
Contributor Author

@whimboo I've reverted the non-removal/cleanup commits.

@whimboo
Copy link
Contributor

whimboo commented Sep 30, 2015

There are still 24 changed files. What I want is the version of the PR you had at first when I reviewed it. I think it would be good if you better get rid of all those extra commits.

@UtiluMark
Copy link
Contributor Author

@whimboo OK, I've reverted everything except the removal of the three unused files.

@whimboo
Copy link
Contributor

whimboo commented Sep 30, 2015

That looks fine now. Thanks. I will get the commits squashed and merged to master.

@whimboo
Copy link
Contributor

whimboo commented Sep 30, 2015

PR got merged to master as eff8f9e.

Now you can create a new PR with all the coding style changes. :) I would suggest that you make use of a new branch in your repository so that you don't destroy your master branch. Thanks again.

@whimboo whimboo closed this Sep 30, 2015
@UtiluMark
Copy link
Contributor Author

@whimboo I've created PR #189 for one commit UtiluMark@878c788 Removed excessive white space before line endings and fixed indentation by always using spaces and never using tabs.

@whimboo
Copy link
Contributor

whimboo commented Oct 1, 2015

Thank you for the other PR. Best would be to simply add a comment on the newly created PR. That one is actually closed. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants