Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ja-JP locale #200

Closed
wants to merge 13 commits into from
Closed

Add ja-JP locale #200

wants to merge 13 commits into from

Conversation

Cai0407
Copy link
Contributor

@Cai0407 Cai0407 commented Oct 14, 2015

Please add ja-JP locale.

@xabolcs
Copy link
Collaborator

xabolcs commented Oct 15, 2015

Hi there!

Thanks for contributing!
Let's postpone reviewing (and landing) this PR for a few commits. There are pending string changes in the PR list.

@Cai0407
Copy link
Contributor Author

Cai0407 commented Oct 16, 2015

@xabolcs I see. I will wait for the completion of string changes.

@whimboo
Copy link
Contributor

whimboo commented Nov 10, 2015

I think we can continue here given that all? necessary changes have been landed meanwhile? @xabolcs can you please check?

@xabolcs
Copy link
Collaborator

xabolcs commented Nov 13, 2015

It would be nice to land #93 and #137 before reviewing this.

@UtiluMark
Copy link
Contributor

#188 will also add a few strings to the translation files.

@Cai0407
Copy link
Contributor Author

Cai0407 commented Aug 20, 2016

Version 3.8 seems to be released soon.
Can I resume update of ja-JP locale now?

@UtiluMark
Copy link
Contributor

Note: pending issue #188 will add a few new strings to the translation files.

@xabolcs
Copy link
Collaborator

xabolcs commented Aug 20, 2016

@whimboo, it would be nice to clarify what to ship with 3.9 release and let @Cai0407 resume update of ja-JP locale.

@whimboo
Copy link
Contributor

whimboo commented Aug 22, 2016

@xabolcs, I wouldn't add too much for a new release. It would be better to release more often instead. So I only moved all not-fixed-yet issues from 3.8 to 3.9. Also I think we shouldn't wait to long for localizers to update their locale. They should be able to do it at any time, but may have to do it again in case something else gets changed soon after.

I'm happy to get this merged after we proofed the correctness of the strings.

reflect addition of pl
add description for ja-JP and reflect addition of pl
reflect to crashme-simple
@Cai0407
Copy link
Contributor Author

Cai0407 commented Oct 13, 2016

I have created revised PR #226.

@whimboo
Copy link
Contributor

whimboo commented Oct 13, 2016

There is usually no need to create a new PR. In case of conflicts those need to be resolved locally and force pushed to your remote branch. For this time lets continue on PR #226.

@whimboo whimboo closed this Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants