-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap train-taskcluster.sh in train_taskcluster.py #546
Conversation
I'm concerned about the number of wrappings in our training. We have: Marian wrapped by OpusTrainer wrapped by I strongly recommend rewriting |
I'm a bit hesistant to do take that on as something that blocks turning spot instances back on, since we're on a tight timeline, and it's difficult to test all of the training continuation scenarios, but I can if you'd like. Alternatively, I can follow up with it later, after we've branched for the upcoming trainings. |
Sure, it's up to you, fixing this as a follow-up works for me. |
cb207f3
to
43bbc78
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with merging this to unblock spot instances but please add a TODO and an issue to rewrite this in Python to reduce wrapping and complexity.
In order to support automatic continuation of spot terminated training runs (#270) I'll need to do some non-trivial things before handing off to
train.sh
. Rather than try to do them in bash, I'd like to do them in Python. This PR should have no behavioru differences, but it lays a foundation for this upcoming work. It would also be a good basis for replacingtrain-taskcluster.sh
with Python entirely in the future.