Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rerun for random walk samplers #68

Merged
merged 22 commits into from
Oct 23, 2024
Merged

Implement rerun for random walk samplers #68

merged 22 commits into from
Oct 23, 2024

Conversation

edknock
Copy link
Contributor

@edknock edknock commented Sep 5, 2024

No description provided.

@edknock edknock requested a review from richfitz September 10, 2024 10:48
@thomrawson
Copy link

Just sharing my own success with the use of this rerun feature.
Before re-runs enabled:
00_all_plot

And after re-runs enabled:
00_all_plot

Thanks Ed! :)

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.46%. Comparing base (f712d7b) to head (a0cd09f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          69       69           
  Lines        5187     5203   +16     
=======================================
+ Hits         5159     5175   +16     
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

##'
##' @return A `monty_sampler` object, which can be used with
##' [monty_sample]
##'
##' @export
monty_sampler_random_walk <- function(vcv = NULL, boundaries = "reflect") {
monty_sampler_random_walk <- function(vcv = NULL, boundaries = "reflect",
rerun_every = Inf, rerun_random = FALSE) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to make rerun_random = TRUE the default? I feel that's what most people preferred in the end

@richfitz richfitz merged commit 070b112 into main Oct 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants