Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix depthTest in logarithmicDepthBuffer #30214

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 26, 2024

Related issue: #30203, #29799

Description

Calculate the depth should be required for depth testing, but it won't necessarily write once it is disabled in the pipeline if material.depthWrite is false.

Copy link

github-actions bot commented Dec 26, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.44
79.06
339.44
79.06
+0 B
+0 B
WebGPU 488.27
135.68
488.29
135.69
+21 B
+9 B
WebGPU Nodes 487.74
135.56
487.76
135.57
+21 B
+11 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.3
112.11
465.3
112.11
+0 B
+0 B
WebGPU 558.06
151.21
558.08
151.22
+21 B
+8 B
WebGPU Nodes 514.13
140.95
514.15
140.96
+21 B
+7 B

@sunag sunag marked this pull request as ready for review December 26, 2024 18:00
@sunag sunag added this to the r172 milestone Dec 26, 2024
@sunag sunag merged commit 688976a into mrdoob:dev Dec 26, 2024
12 checks passed
@sunag sunag deleted the dev-fix-depth-log branch December 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant