Add blendFactor support to CCDIKSolver #30406
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to control IK influence through blend factors: - Global blendFactor in update() method - Per-chain blendFactor in updateOne() method - Default value of 1.0 maintains backward compatibility
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Mugen87
reviewed
Jan 27, 2025
| @@ -63,16 +62,17 @@ class CCDIKSolver { | |||
|
|
|||
| /** | |||
| * Update all IK bones. | |||
| * | |||
| * @param {number} [globalBlendFactor=1.0] - Blend factor applied if an IK chain doesn't have its own .blendFactor. | |||
There was a problem hiding this comment.
Formatting seems to be broken here.
Mugen87
reviewed
Jan 27, 2025
| for ( let j = 0; j < links.length; j ++ ) { | ||
|
|
||
| const linkIndex = links[ j ].index; | ||
| initialQuaternions[ j ] = bones[ linkIndex ].quaternion.clone(); |
There was a problem hiding this comment.
This method is called for every animation step for each IK bone for all its links. It is unacceptable to use clone() in such hot code paths.
Mugen87
reviewed
Jan 27, 2025
| limitation.y * c2, | ||
| limitation.z * c2, | ||
| c | ||
| ); |
There was a problem hiding this comment.
Please avoid reformatting so it's easier to see what you actually change in the source file.
* TSLEncoder: Fix number imports. * GLSLDecoder: Improve uint support. * GLSLDecoder: Fix CodeQL feedback.
Co-authored-by: Samuel Rigaud <[email protected]>
Co-authored-by: Samuel Rigaud <[email protected]>
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added ability to control IK influence through blend factors:
Use Case
I was developing an animation + procedural animation system and needed smooth interpolation between animation clips and IK implementation. Since the overrides happen in the CCDIKSolver, modifying it to support blending was necessary.
Usage Example
CS_009266.2025-01.mp4
Alternative Approaches Considered