WebGPURenderer: Fix color space of clear colors. #30488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
commented
Feb 9, 2025
| @@ -64,14 +64,14 @@ class Background extends DataMap { | |||
|
|
|||
| // no background settings, use clear color configuration from the renderer | |||
|
|
|||
| renderer._clearColor.getRGB( _clearColor, LinearSRGBColorSpace ); | |||
| renderer._clearColor.getRGB( _clearColor ); | |||
There was a problem hiding this comment.
Better to not use LinearSRGBColorSpace and use the default ColorManagement.workingColorSpace which is LinearSRGBColorSpace.
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #30485.
Description
Backend.getClearColor()must return the color in working color space.