3MFLoader: Fix parsing of assets with sub models. #30491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Feb 10, 2025
Jack-J-Young
force-pushed
the
3mf-prod-fix
branch
from
a81e8d4 to
b84c8f1
Compare
Clean up.
Mugen87
approved these changes
Feb 10, 2025
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30174
Description
Some 3MF files with with production extension would not load as the root model can contain a path key used to reference a models outside the current file (still in the 3MF archive)
Only the root model can contain these references so reversing the build order is a simple fix for this.
Ref (Chapter 2):
Further, only a component element in the root model file MAY contain a path attribute. Non-root model file components MUST only reference objects in the same model file.There are models with the extension to test in the related issue, I also tested models without and they were unaffected.