MTLLoader: Add support for displacement maps. #30508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
reviewed
Feb 12, 2025
Mugen87
reviewed
Feb 12, 2025
Mugen87
changed the title
|
Sorry about that. When I saved the file it was reformatted. I saved it now
without formatting.
Should be fine now ...
…On Wed, Feb 12, 2025 at 9:48 AM Michael Herzog ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In examples/jsm/loaders/MTLLoader.js
<#30508 (comment)>:
> @@ -443,6 +443,13 @@ class MaterialCreator {
break;
+ case 'disp':
Please honor the formatting of the file.
—
Reply to this email directly, view it on GitHub
<#30508 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHYIIW2JANRHLOHHG7XTALL2PM7ITAVCNFSM6AAAAABW7MZDCGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMMJRHAYTGNJYGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Paulo Roma Cavalcanti
LCG - UFRJ
|
Mugen87
approved these changes
Feb 12, 2025
This was referenced Feb 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #71200
Description
I am proposing adding a displacement map to mtl files
The changes are very simple and I have an app displaying the result
Note: this is my first attempt of doing a "push request" and I am not sure if I did it correctly. Sorry in advance...