Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jsdoc: enable eslint rule valid-jsdoc.preferType #30509

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

s-rigaud
Copy link
Contributor

Description

In the same spirit as #30466 which tries to update code as close to Jsdoc official typing as possible, I added the eslint rule valid-jsdoc.preferType to enforce eslint to follow the official doc for future development.

I re-run all the linting commands, found nothing to update in the core folder as everything was nicely updated in the previous PR but I updated the files that needed changes in other folders to avoid adding additional linting errors.

@s-rigaud s-rigaud force-pushed the implement-valid-jsdoc-preferType branch 2 times, most recently from d88fa40 to 6a9b721 Compare February 12, 2025 15:13
@Mugen87 Mugen87 merged commit a918bcd into mrdoob:dev Feb 12, 2025
11 checks passed
@Mugen87 Mugen87 added this to the r174 milestone Feb 12, 2025
@s-rigaud s-rigaud deleted the implement-valid-jsdoc-preferType branch February 17, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants