Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved CI - check fmt #156

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Improved CI - check fmt #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57c10b8
Improved CI
alfonsorr Sep 11, 2024
e64eca8
Update spark versions to latest.
alfonsorr Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions .github/workflows/ci-quality.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
name: CI-quality
on:
push:
branches:
- main
pull_request:

jobs:
build:
strategy:
fail-fast: false
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: coursier/cache-action@v6
with:
extraKey: quality-check
- uses: coursier/setup-action@v1
with:
jvm: zulu:8
- name: ScalaFmt
id: fmt
run: sbt scalafmtCheckAll
11 changes: 8 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,16 @@ jobs:
strategy:
fail-fast: false
matrix:
spark: ["3.1.3","3.2.1", "3.3.2", "3.4.3", "3.5.1"]
spark: ["3.1.3","3.2.4", "3.3.4", "3.4.3", "3.5.1"]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: olafurpg/setup-scala@v10
- uses: actions/checkout@v4
- uses: coursier/cache-action@v6
with:
extraKey: ${{ matrix.spark }}
- uses: coursier/setup-action@v1
with:
jvm: zulu:8
- name: Test
run: sbt -Dspark.testVersion=${{ matrix.spark }} +test
- name: Benchmark
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/com/github/mrpowers/spark/fast/tests/SchemaComparer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ object SchemaComparer {
ignoreNullable: Boolean = false,
ignoreColumnNames: Boolean = false,
ignoreColumnOrder: Boolean = true
) = {
): Unit = {
require((ignoreColumnNames, ignoreColumnOrder) != (true, true), "Cannot set both ignoreColumnNames and ignoreColumnOrder to true.")
if (!SchemaComparer.equals(actualDS.schema, expectedDS.schema, ignoreNullable, ignoreColumnNames, ignoreColumnOrder)) {
throw DatasetSchemaMismatch(
Expand Down